Add ability to use LoomProvider with the /eth endpoint#299
Merged
Conversation
# Conflicts: # e2e_tests.sh
redben
commented
Aug 21, 2019
enlight
requested changes
Aug 21, 2019
- remove Client.readClient - Client.sendWeb3MsgAsync - Client.sendWeb3MsgAsync revert code in getevmfilterchanges - update LoomProvider accordingly
enlight
requested changes
Aug 22, 2019
- ClientEvent.EVMEvent - catch on test - readerSuffix
(.blockNumber does not seem to be used by web3, keeping it there to not break stuff)
Contributor
Author
|
One test still fails... didn't we disable blueprint? Calls via HTTP |
Just to test that we didn't break interaction with Go contracts. BluePrint will get replaced by the SampleGoContract in the near future.
This reverts commit cebfaa2.
enlight
changed the title
enlight
changed the title
Contributor
|
This is an intermediate step that will allow us to start using the Web3 JSON-RPC methods provided by Loom nodes on the One annoying limitation of the changes in this PR is that a single |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.