Open
Conversation
|
Owner
|
Thanks for this patch. I'll pull your branch in to do some testing on my side before merging into the (I'm sure you're tested this thoroughly yourself but this change touches on some heavily used routines so it's worth having a 2nd person double checking too) |
Author
|
Sounds good, appreciate you double-checking it. Let me know if anything comes up during testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #987
The issue was that stdin was getting closed before the write completed. Moving the close call after the write ensures the data actually gets flushed to the unmarshaller. This was preventing su root and similar commands from working properly.