-
Notifications
You must be signed in to change notification settings - Fork 0
feat: lvt-preserve attributes, __navigate__ SPA nav, DOMParser script fix #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
171ba21
feat(client): lvt-preserve attributes and __navigate__ in-band SPA nav
adnaan ae84769
fix(updateDOM): use DOMParser for script-containing HTML + regression…
adnaan 0c19f00
fix: address bot review comments — case-insensitive script detection,…
adnaan 374b357
fix: pathname guard for sameWrapper sendNavigate + replaceChildren re…
adnaan 7787453
fix: tighten script detection regex, fix mock type, document unreacha…
adnaan 520a015
fix: remove dead sameWrapper branch, guard sendNavigate on WS state, …
adnaan a0729b5
fix: correct sendNavigate WS guard condition (|| not &&), drop unused…
adnaan b7540ae
fix: check toEl for lvt-preserve (server can remove it), document sca…
adnaan f679289
fix(review): address bot review round 7 feedback
adnaan 66e1b75
fix(review): address bot review round 8 feedback
adnaan bf7e4fa
fix(review): address bot review round 9 feedback
adnaan 84be745
fix(review): address bot review round 10 feedback
adnaan db6b0f3
fix(review): address bot review round 11 feedback
adnaan 88d430b
fix(review): address bot review round 12 feedback
adnaan 1e59ba5
fix(review): address bot review round 13 feedback
adnaan 324bf06
fix(review): address bot review round 14 feedback
adnaan cd51742
fix(review): address bot review round 15 feedback
adnaan d0e80f5
docs(review): address bot review round 16 feedback
adnaan 903b286
fix(review): address bot review round 17 feedback
adnaan 1fb388c
fix(review): address bot review round 18 feedback
adnaan 830e3f3
fix(review): address bot review round 19 feedback
adnaan a51ef3c
fix(review): address bot review round 20 feedback
adnaan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same-pathname fast path returns before aborting any in-flight navigation fetch. If a user clicks a cross-path link (starting a fetch) and then quickly clicks a same-pathname link, the earlier fetch can still resolve later and call handleNavigationResponse, racing with the in-band navigate update. Consider aborting any existing abortController (and clearing it) before the fast-path return as well.