This repository was archived by the owner on Oct 26, 2022. It is now read-only.
Rename metadata to response_tx, remove Metadata generic#260
Open
stbuehler wants to merge 2 commits intolittle-dude:masterfrom
Open
Rename metadata to response_tx, remove Metadata generic#260stbuehler wants to merge 2 commits intolittle-dude:masterfrom
stbuehler wants to merge 2 commits intolittle-dude:masterfrom
Conversation
The metadata is always the channel to send the response to; this makes this fact clearer and reduces generic type overhead a little bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this: I'd like to give #138 a shot (before moving #170 forward).
The
metadatafield makes changes in that area rather unreadable, so I'd like to clean this up in a separate step.