fix: fix icon positioning with device pixel ratio

src/private/dquickdciiconimage.cpp

@@ -6,9 +6,11 @@
 
 #include <DIconTheme>
 #include <DGuiApplicationHelper>
 #include <DPlatformTheme>
 
 #include <QUrlQuery>
+#include <QQuickWindow>
+#include <QPoint>
 
 DQUICK_BEGIN_NAMESPACE
 DGUI_USE_NAMESPACE
@@ -189,8 +191,43 @@
 
 void DQuickDciIconImagePrivate::layout()
 {
-    auto dd = QQuickItemPrivate::get(imageItem);
-    dd->anchors()->setCenterIn(imageItem->parentItem());
+    Q_Q(DQuickDciIconImage);
+    if (!q->isComponentComplete())
+        return;
+
+    qreal targetX = (q->width() - imageItem->width()) / 2.0;
+    qreal targetY = (q->height() - imageItem->height()) / 2.0;
+
+    if (!q->parentItem() || !q->window()) {
+        imageItem->setPosition(QPointF(targetX, targetY));
+        return;
+    }
+
+    QPointF scenePos = q->mapToScene(QPointF(targetX, targetY));
+
+    qreal dpr = q->window()->effectiveDevicePixelRatio();
+
+    qreal physicalX = qRound(scenePos.x() * dpr);
+    qreal physicalY = qRound(scenePos.y() * dpr);
+
+    QPointF localPos = q->mapFromScene(QPointF(physicalX / dpr, physicalY / dpr));
+
+    imageItem->setPosition(localPos);
+}
+
+void DQuickDciIconImagePrivate::scheduleLayout()
+{
+    Q_Q(DQuickDciIconImage);
+
+    if (!layoutTimer) {
+        layoutTimer = new QTimer(q);
+        layoutTimer->setSingleShot(true);
+        layoutTimer->setInterval(50);
+        QObject::connect(layoutTimer, &QTimer::timeout, q, [this]() {
+            layout();
+        });
+    }
+    layoutTimer->start();
 }
 
 void DQuickDciIconImagePrivate::updateImageSourceUrl()
@@ -211,6 +248,9 @@
     connect(d->imageItem, &QQuickImage::implicitWidthChanged, this, [this, d]() { setImplicitWidth(d->imageItem->implicitWidth()); });
     connect(d->imageItem, &QQuickImage::implicitHeightChanged, this, [this, d]() { setImplicitHeight(d->imageItem->implicitHeight()); });
     connect(this, &DQuickDciIconImage::smoothChanged, d->imageItem, &QQuickImage::setSmooth);
+    connect(d->imageItem, &QQuickItem::widthChanged, this, [d]() { d->scheduleLayout(); });
+    connect(d->imageItem, &QQuickItem::heightChanged, this, [d]() { d->scheduleLayout(); });
+    connect(this, &QQuickItem::scaleChanged, this, [this]() {setSmooth(!qFuzzyCompare(scale(), 1.0)); });
 }
 
 DQuickDciIconImage::~DQuickDciIconImage()
@@ -406,17 +446,39 @@
     D_D(DQuickDciIconImage);
     QQmlEngine::setContextForObject(d->imageItem, QQmlEngine::contextForObject(this));
     QQuickItem::classBegin();
-    d->imageItem->setSmooth(smooth());
 }
 
 void DQuickDciIconImage::componentComplete()
 {
     D_D(DQuickDciIconImage);
     d->imageItem->componentComplete();
     QQuickItem::componentComplete();
+    setSmooth(!qFuzzyCompare(scale(), 1.0));
     d->layout();
 }
 
+#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
+void DQuickDciIconImage::geometryChanged(const QRectF &newGeometry, const QRectF &oldGeometry)
+{
+    QQuickItem::geometryChanged(newGeometry, oldGeometry);
+    d_func()->scheduleLayout();
+}
+#else
+void DQuickDciIconImage::geometryChange(const QRectF &newGeometry, const QRectF &oldGeometry)
+{
+    QQuickItem::geometryChange(newGeometry, oldGeometry);
+    d_func()->scheduleLayout();
+}
+#endif
+
+void DQuickDciIconImage::itemChange(ItemChange change, const ItemChangeData &value)
+{
+    QQuickItem::itemChange(change, value);
+    if (change == ItemParentHasChanged || change == ItemDevicePixelRatioHasChanged || change == ItemSceneChange) {
+        d_func()->scheduleLayout();
+    }
+}
+
 class DQuickIconAttachedPrivate : public DCORE_NAMESPACE::DObjectPrivate
 {
     D_DECLARE_PUBLIC(DQuickIconAttached)

src/private/dquickdciiconimage_p.h

@@ -105,6 +105,12 @@ class DQuickDciIconImage : public QQuickItem, DCORE_NAMESPACE::DObject
 protected:
     void classBegin() override;
     void componentComplete() override;
+#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
+    void geometryChanged(const QRectF &newGeometry, const QRectF &oldGeometry) override;
+#else
+    void geometryChange(const QRectF &newGeometry, const QRectF &oldGeometry) override;
+#endif
+    void itemChange(ItemChange change, const ItemChangeData &value) override;
 };
 
 class DQuickIconAttachedPrivate;

src/private/dquickdciiconimage_p_p.h

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2022 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2022 - 2026 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: LGPL-3.0-or-later
 
@@ -10,9 +10,10 @@
 #include "dquickdciiconimage_p.h"
 #include "dquickiconimage_p_p.h"
 
 #include <dobject_p.h>
 #include <DDciIconPalette>
 #include <DDciIconPlayer>
+#include <QTimer>
 
 DQUICK_BEGIN_NAMESPACE
 class DQuickDciIconImageItemPrivate;
@@ -41,11 +42,13 @@
 public:
     DQuickDciIconImagePrivate(DQuickDciIconImage *qq);
     void layout();
+    void scheduleLayout();
     void updateImageSourceUrl();
     void play(DQMLGlobalObject::ControlState mode);
 
     DDciIconPalette palette;
     DQuickIconImage *imageItem;
+    QTimer *layoutTimer = nullptr;
     DQMLGlobalObject::ControlState mode = DQMLGlobalObject::NormalState;
     DGuiApplicationHelper::ColorType theme = DGuiApplicationHelper::ColorType::LightType;
     bool fallbackToQIcon = true;