fix: Fix sw64 gcc not support pie by default#201
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:develop/snipefrom Jan 4, 2026
Merged
fix: Fix sw64 gcc not support pie by default#201deepin-bot[bot] merged 1 commit intolinuxdeepin:develop/snipefrom
deepin-bot[bot] merged 1 commit intolinuxdeepin:develop/snipefrom
Conversation
Add the -fPIE parameter via CMAKE_POSITION_INDEPENDENT_CODE. Add the -pie parameter via target_link_options. Log: Update compiler flags for security enhancements Bug: https://pms.uniontech.com/bug-view-339563.html
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnables position-independent code globally and links all main executables with PIE on sw64 by setting CMake’s global PIC flag and adding -pie link options to core targets. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Enabling
CMAKE_POSITION_INDEPENDENT_CODEglobally may affect all targets (including shared libraries); consider restricting this to the specific executables or to the sw64 toolchain via appropriate CMake conditionals. - The use of
target_link_optionsrequires a newer CMake version than the currentcmake_minimum_required(VERSION 3.1.0); either bump the minimum required version or gate this behind a version check and use a fallback for older CMake. - The
-pielink option is added unconditionally; consider applying it only when using GCC on sw64 (or when the compiler/linker supports PIE) to avoid build issues on other platforms/toolchains.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Enabling `CMAKE_POSITION_INDEPENDENT_CODE` globally may affect all targets (including shared libraries); consider restricting this to the specific executables or to the sw64 toolchain via appropriate CMake conditionals.
- The use of `target_link_options` requires a newer CMake version than the current `cmake_minimum_required(VERSION 3.1.0)`; either bump the minimum required version or gate this behind a version check and use a fallback for older CMake.
- The `-pie` link option is added unconditionally; consider applying it only when using GCC on sw64 (or when the compiler/linker supports PIE) to avoid build issues on other platforms/toolchains.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
lzwind
approved these changes
Jan 4, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, wangrong1069 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the -fPIE parameter via CMAKE_POSITION_INDEPENDENT_CODE. Add the -pie parameter via target_link_options.
Log: Update compiler flags for security enhancements
Bug: https://pms.uniontech.com/bug-view-339563.html
Summary by Sourcery
Enable position-independent code and PIE linking for all targets to address sw64 GCC default PIE support issues.
Build: