Skip to content

fix: allow right-click long press to trigger context menu on touchscreen #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wjyrich wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

fix: allow right-click long press to trigger context menu on touchscreen #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qml/IconItemDelegate.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ Control {
}
// touchscreen long press.
onPressAndHold: function (mouse) {
if (mouse.button === Qt.NoButton) {
if (mouse.button === Qt.NoButton ||| mouse.button === Qt.RightButton) {
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Fix the ||| operator, which is invalid JavaScript/QML syntax.

Use || here (as in the other handlers) so the condition parses correctly and matches the intended NoButton or RightButton behavior.

root.menuTriggered()
}
}
Expand Down
2 changes: 1 addition & 1 deletion qml/windowed/AppListView.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ FocusScope {
}
// touchscreen long press.
onPressAndHold: function (mouse) {
if (mouse.button === Qt.NoButton) {
if (mouse.button === Qt.NoButton || mouse.button === Qt.RightButton) {
showContextMenu(itemDelegate, model)
}
}
Expand Down
2 changes: 1 addition & 1 deletion qml/windowed/FreeSortListView.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ Item {

// touchscreen long press.
onPressAndHold: function (mouse) {
if (mouse.button === Qt.NoButton) {
if (mouse.button === Qt.NoButton || mouse.button === Qt.RightButton) {
showContextMenu(itemDelegate, model, {
hideMoveToTopMenu: index === 0
})
Expand Down
2 changes: 1 addition & 1 deletion qml/windowed/IconItemDelegate.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ Control {
}
// touchscreen long press.
onPressAndHold: function (mouse) {
if (mouse.button === Qt.NoButton) {
if (mouse.button === Qt.NoButton || mouse.button === Qt.RightButton) {
root.menuTriggered()
}
}
Expand Down
Loading