Add option for strings to appear in structured judgments#25
Merged
liamoc merged 22 commits intoliamoc:mainfrom Mar 20, 2026
Merged
Add option for strings to appear in structured judgments#25liamoc merged 22 commits intoliamoc:mainfrom
liamoc merged 22 commits intoliamoc:mainfrom
Conversation
Contributor
Author
liamoc
approved these changes
Mar 20, 2026
Owner
liamoc
left a comment
There was a problem hiding this comment.
Minor changes to substDeBruijn interface
Substitution must now potentially throw an exception (which is part of the signature).
this means unification will discard solutions that lead to throwing substitutions.
proof method apply() will fail for throwing substitutions
when substitution is applied to the entire proof after a method is selected, if substitution fails THEN (unlikely but possible), an error must be reported to the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is a WIP so will add more detail later, but the gist is that we want to allow string terms to appear in the structured part of their judgments to allow for e.g. carrying through identifiers into a built up parse tree:
Have implemented this by parameterising
SExpover aSymbolmodule, which in the case of bare S-expressions is just a thin wrapper aroundstring, and in the case of string term judgments is a wrapper aroundstring | StringTerm.t.