Conversation
Yurlungur
approved these changes
Aug 22, 2025
Collaborator
Yurlungur
left a comment
Yurlungur
left a comment
There was a problem hiding this comment.
This is a welcome addition! A few nitpicks and suggestions below. But it's all optional, we can merge when you're happy with it.
Collaborator
Author
|
@Yurlungur , I've addressed all of the suggestions. I'm fairly certain that I have adopted all suggestions. Please check to make sure that you like the direction of the changes. If so, I'm ready for you to approve merge if all looks good to you as well. |
Yurlungur
approved these changes
Aug 29, 2025
Collaborator
Yurlungur
left a comment
Yurlungur
left a comment
There was a problem hiding this comment.
Looks good! Thanks @curiousmiah !
Comment on lines
+9
to
+19
| #On Polaris, you need to create a conda environment via... | ||
| #If phoebuspy conda environment is already active | ||
| #conda deactivate | ||
| #If you want to delete the old environment and start from scratch. | ||
| #module unload xalt | ||
| #conda env remove -n phoebuspy | ||
| #If you want to create the phosbuspy conda environment | ||
| #conda create -n phoebuspy numpy numexpr matplotlib h5py scipy pyyaml -y | ||
| #The above needs to be once to define the environment... | ||
| #Do this every time you need to use python on Polaris | ||
| #conda activate phoebuspy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR provides new diagnostic tools in phoebuspy.py. In particular it includes capabilities to plot and make movies of slices of 3D simulations. It includes 2D slices and 1D slices. In addition, there was a bug in Phoebus when including flux_divergence and src_terms in the output. This has been fixed.
PR Checklist
scripts/bash/format.sh.