Fixed logic errors in history.cpp and progenitordata.cpp that caused …#239
Merged
Fixed logic errors in history.cpp and progenitordata.cpp that caused …#239
Conversation
…failures for runs with radiation turned off.
Collaborator
|
Can't look at this for a few days but the changes worked for me, pinging @Yurlungur if you have time. |
Yurlungur
approved these changes
Aug 1, 2025
Collaborator
Yurlungur
left a comment
Yurlungur
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…failures for runs with radiation turned off.
PR Summary
Checks of whether radiation is active were not being done when computing various gain region quantities. This caused failures, for example, for homologous.pin. This PR implements those checks and leads to homologous.pin running without issue.
PR Checklist
scripts/bash/format.sh.