Adding and updating features for TOV 1D#237
Merged
Conversation
curiousmiah
requested review from
AstroBarker,
Yurlungur,
carlnotsagan and
mari2895
Yurlungur
requested changes
Jun 10, 2025
Collaborator
Yurlungur
left a comment
Yurlungur
left a comment
There was a problem hiding this comment.
Mostly looks good. Some minor nitpicks below.
mari2895
reviewed
Jun 11, 2025
|
|
||
| <parthenon/time> | ||
| nlim = -1 # cycle limit | ||
| tlim = 5000 # time limit |
Collaborator
There was a problem hiding this comment.
I see you changed tlim here. Did you make sure everything is reasonable at later times too? I remember at one point things getting messed up after 1000, and probably it is a good idea to make sure the results are still reasonable beyond 1000.
Collaborator
Author
There was a problem hiding this comment.
Indeed, we should run it longer. I recommend that we leave it at the shorter time in the default tov.pin. In that way, the default is a short run that is appropriate for quick debugging. If someone wants to test it for longer (which we do), then they can change tlim to something longer.
Yurlungur
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
In this pull request, I am adding features to run and debug the TOV 1D problem. In particular, I have added a general phoebuspy.py module for plotting purposes. I have also changed the tov.pin input file to simulate a more compact TOV star. This more compact TOV star is more relativistic than the older TOV star input file. The input file also include floors that work for the problem.
Separately, I tried to make the Monopole solver more accurate by using an rk4 integrator. However, this did not lead to improved accuracy. You will notice that I have commented the rk4 integration scheme, and I have left the original integration scheme. I am not done figuring out how to make the monopole solver more accurate, so I recommend that we leave the commented rk4 version.
PR Checklist
scripts/bash/format.sh.