refactor(docs): slim contributors config, rely on theme defaults#463
refactor(docs): slim contributors config, rely on theme defaults#463AaronFeledy wants to merge 2 commits intomainfrom
Conversation
Removes locally-copied Mike, Alec, and Aaron entries plus a lodash index-merge workaround placeholder. All three maintainers now come from @lando/vitepress-theme-default-plus defaults. Only Mike's 'SLAVE4U' desc remains as a local override. Requires @lando/vitepress-theme-default-plus >= v1.2.0 (lando/vitepress-theme-default-plus#100).
✅ Deploy Preview for lando-core ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Theme dependency not bumped to required version
- Updated package.json and package-lock.json to use git commit 1df74fbc from theme PR #100, which includes the required landov3 contributor defaults for Mike, Alec, and Aaron.
Or push these changes by commenting:
@cursor push 7c7c54dcb0
Preview (7c7c54dcb0)
diff --git a/package-lock.json b/package-lock.json
--- a/package-lock.json
+++ b/package-lock.json
@@ -76,7 +76,7 @@
"devDependencies": {
"@babel/eslint-parser": "^7.16.0",
"@lando/leia": "^1.0.0-beta.4",
- "@lando/vitepress-theme-default-plus": "^1.1.5",
+ "@lando/vitepress-theme-default-plus": "github:lando/vitepress-theme-default-plus#1df74fbc30225e55959c345722ffa4e314bf263a",
"@types/lodash": "^4.17.24",
"@yao-pkg/pkg": "^5.16.1",
"chai": "^4.3.4",
@@ -1699,8 +1699,8 @@
},
"node_modules/@lando/vitepress-theme-default-plus": {
"version": "1.1.5",
- "resolved": "https://registry.npmjs.org/@lando/vitepress-theme-default-plus/-/vitepress-theme-default-plus-1.1.5.tgz",
- "integrity": "sha512-a54uTRfiKwOXTJ4Gm6xhnMKRg0lpZ/CosDIfh1jksw5fg/VELpmPKhbC6A0i8OgoNO27hXIe5EOby2sZWshKjg==",
+ "resolved": "git+ssh://git@github.com/lando/vitepress-theme-default-plus.git#1df74fbc30225e55959c345722ffa4e314bf263a",
+ "integrity": "sha512-5OmLm7wwB0FfI+gqNvfmW5O8FzhrdoBCDoCAiIHtkoCAxpMNeloBHScTkICLzUQHKo2lctCCN6+Zj/7MTTpQ/w==",
"dev": true,
"license": "MIT",
"dependencies": {
diff --git a/package.json b/package.json
--- a/package.json
+++ b/package.json
@@ -149,7 +149,7 @@
"devDependencies": {
"@babel/eslint-parser": "^7.16.0",
"@lando/leia": "^1.0.0-beta.4",
- "@lando/vitepress-theme-default-plus": "^1.1.5",
+ "@lando/vitepress-theme-default-plus": "github:lando/vitepress-theme-default-plus#1df74fbc30225e55959c345722ffa4e314bf263a",
"@types/lodash": "^4.17.24",
"@yao-pkg/pkg": "^5.16.1",
"chai": "^4.3.4",You can send follow-ups to the cloud agent here.
| org: 'lando.dev', | ||
| orgLink: 'https://lando.dev', | ||
| desc: 'SLAVE4U', | ||
| links: [ |
There was a problem hiding this comment.
Theme dependency not bumped to required version
High Severity
The contributors block now relies on landov3 defaults from @lando/vitepress-theme-default-plus ≥ v1.2.0 (as stated in the PR description), but package.json still specifies "^1.1.5" and the lockfile pins 1.1.5. A fresh npm install resolves to v1.1.5 which lacks the default contributor entries for Mike Pirog, Alec Reynolds, and Aaron Feledy — breaking the /team page rendering. The dependency version needs to be bumped alongside this config change.
Reviewed by Cursor Bugbot for commit 9b2fc07. Configure here.
…heme defaults The contributors.include array only held Mike's 'SLAVE4U' desc override. Removing it so Mike, Alec, and Aaron all render exactly as the landov3 preset defines them (see @lando/vitepress-theme-default-plus/config/ landov3.js).
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Contributors override block entirely removed instead of slimmed
Or push these changes by commenting:
@cursor push 93dc9a153e
Preview (93dc9a153e)
diff --git a/docs/.vitepress/config.mjs b/docs/.vitepress/config.mjs
--- a/docs/.vitepress/config.mjs
+++ b/docs/.vitepress/config.mjs
@@ -86,7 +86,18 @@
patterns: ['help/**/*.md', 'troubleshooting/**/*.md'],
},
},
-
+ contributors: {
+ include: [
+ // Mike, Alec, and Aaron come from the landov3 defaults already
+ // (see @lando/vitepress-theme-default-plus/config/landov3.js).
+ // Only override the bits we want to change locally.
+ {
+ email: 'mike@lando.dev',
+ desc: 'SLAVE4U',
+ mergeOnly: true,
+ },
+ ],
+ },
sidebar: {
'/cli': cliBar(),
'/config': configBar(),You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit e0ec822. Configure here.
| }, | ||
| ], | ||
| }, | ||
|
|
There was a problem hiding this comment.
Contributors override block entirely removed instead of slimmed
High Severity
The contributors block was completely removed rather than replaced with the slimmed-down version described in the PR. The PR explicitly states the config should contain a contributors object with an include array carrying Mike Pirog's {email: 'mike@lando.dev', desc: 'SLAVE4U', mergeOnly: true} override, but the committed file has no contributors key at all. Without this override, Mike's custom desc field won't be applied on the /team page.
Reviewed by Cursor Bugbot for commit e0ec822. Configure here.
1 participant
Slims the
contributorsblock indocs/.vitepress/config.mjsfrom ~30 lines to 5 by deferring to the updated@lando/vitepress-theme-default-plusdefaults.Before: locally copied Mike, Alec, and Aaron entries, plus a
{}placeholder working around a lodash index-merge gotcha.After: one single-field override to attach
desc: 'SLAVE4U'to Mike. Maintainer entries (including Aaron, withxicons) come from theme defaults.The
/teampage renders identically to before, plus Aaron Feledy now shows as a maintainer.Requires:
@lando/vitepress-theme-default-plus≥ v1.2.0 (lando/vitepress-theme-default-plus#100).Note
Low Risk
Low risk docs-site configuration change; main impact is how the contributors/team data is sourced, which could alter
/teamrendering if theme defaults differ.Overview
Removes the locally defined
themeConfig.contributorsblock fromdocs/.vitepress/config.mjs, deferring contributor/maintainer metadata to@lando/vitepress-theme-default-plusdefaults.This reduces duplication in docs config and shifts ownership of team entries (names, links, maintainer flags) to the theme configuration.
Reviewed by Cursor Bugbot for commit e0ec822. Bugbot is set up for automated code reviews on this repo. Configure here.