Fix file open (ADD) button not opening file picker in Safari#5
Open
lxpollitt wants to merge 1 commit intolanceewing:masterfrom
Open
Fix file open (ADD) button not opening file picker in Safari#5lxpollitt wants to merge 1 commit intolanceewing:masterfrom
lxpollitt wants to merge 1 commit intolanceewing:masterfrom
Conversation
Safari enforces the "user activation" rule for opening native file pickers more strictly than Chrome: .click() on an <input type="file"> must run in the same synchronous event stack as the user-gesture event. HomeScreen.importProgram() was wrapping the call in Gdx.app.postRunnable(...), which defers by one frame — long enough for Safari to revoke the token and silently refuse the picker. Calling synchronously is safe on all three platforms because each DialogHandler.openFileDialog implementation handles its own thread affinity internally (Desktop wraps for Swing, Android uses runOnUiThread, GWT runs synchronously).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari enforces the "user activation" rule for opening native file pickers more strictly than Chrome:
.click()on an<input type="file">must run in the same synchronous event stack as the user-gesture event.HomeScreen.importProgram()was wrapping the call inGdx.app.postRunnable(...), which defers by one frame - long enough for Safari to revoke the token and silently refuse the picker.Calling synchronously is safe on all three platforms because each
DialogHandler.openFileDialogimplementation handles its own thread affinity internally (Desktop wraps for Swing, Android usesrunOnUiThread, GWT runs synchronously).Testing