Change PrawnBlaster read_status to use readline instead of readlines#146
Conversation
|
I have installed this version on my lab's apparatus and confirmed that transition to manual is much faster (no longer noticeable). Experiment behavior seems correct, but it would probably be good to verify that in another environment as well. |
dihm
left a comment
There was a problem hiding this comment.
I'd prefer the solution used in the PrawnDO. Basically, use readline, if there is something up, then run readlines to clear out the full buffer and throw the error. A straight copy-paste of the logic used there should work.
|
That is a good idea; I should have checked the PrawnDO code first. |
I don't know why that |
readlinesrelies on timeouts, so it can be slow. See issue #145 for more details; this PR implements option 1.