Open
Conversation
Comment on lines
+22
to
+24
| '''Remove whitespace because authentication apps often present token | ||
| as "123 456". It is very confusing for user if this exact format | ||
| isn't supported.''' |
Member
There was a problem hiding this comment.
Suggested change
| '''Remove whitespace because authentication apps often present token | |
| as "123 456". It is very confusing for user if this exact format | |
| isn't supported.''' | |
| """Removes whitespace to support tokens like '123 456' shown in authentication apps.""" |
| {"autofocus": "autofocus", "autocomplete": "off"} | ||
| ) | ||
|
|
||
| def clean_otp_token(self): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many (all?) authentication apps present the OTP token e g in groups of three ("123 456"). Users should be able to enter the token like it is presented to them, otherwise it is very confusing. Non-skilled users won't understand why they get an error. This PR fixes this by simply removing all whitespace from token before validating.