Merged
Conversation
Member
NarcisDavins
commented
Mar 16, 2026
NarcisDavins
commented
- Split applier and extractor logic so further improvements can be implemented
- add pools to reuse intermediate slices
- add linear paths for no wildcards cases (including when wildcard is only present on last step)
Signed-off-by: Narcis <narcis.davins@krakend.io>
Signed-off-by: Narcis <narcis.davins@krakend.io>
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Go |  |
Mar 19, 2026 4:44p.m. | Review ↗ |
![deepsource-io[bot]](https://avatars.githubusercontent.com/in/16372?s=60&v=4){kind=small}
Signed-off-by: Narcis <narcis.davins@krakend.io>
kpacha
reviewed
Mar 19, 2026
| if !exists { | ||
| return | ||
| } | ||
| current = v |
Signed-off-by: Narcis <narcis.davins@krakend.io>
NarcisDavins
force-pushed
the
sc-1109/improvements
branch
from
5adae77 to
32768dc
Compare
kpacha
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.