You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey there. I really like the new changes and am getting to know them a bit.
Exploring the Twig docs I came on the "extends" tag and thought I'd attempt a slight restructure on my Stacey fork:
new directory (templates/base) includes base.twig. Kind of a meta-template. It includes the outer html skeleton and blocks for title, content and footer.
Blocks in a .twig can be inherited and-or extended by the revised default.html, page.html. and project.html.
I wonder if you thought of this approach already? In any case I thought you might like to take a look.
I was actually just playing around with this the other day. It's really powerful.
My only concern is that template inheritance might confuse the more non-technical users if we put it in the default template. What are your thoughts?
I see your point that it may intimidate some users or overcomplicate
the default. Twig has a lot more power/complexity beyond extending
templates, which more adventurous users can explore (assuming you're
including access to all of Twig's feature set). So now that I think
about it maybe this doesn't belong in the default template. But a new
alternate template showing this feature could be valuable. I'm hoping
to be ready to submit such a thing pretty soon for your evaluation,
hopefully including some responsive design elements too ...
I was actually just playing around with this the other day. It's really powerful.
My only concern is that template inheritance might confuse the more non-technical users if we put it in the default template. What are your thoughts?
Reply to this email directly or view it on GitHub: #34 (comment)
I would love to see a template with advanced twig functionality, it would be a great learning tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there. I really like the new changes and am getting to know them a bit.
Exploring the Twig docs I came on the "extends" tag and thought I'd attempt a slight restructure on my Stacey fork:
I wonder if you thought of this approach already? In any case I thought you might like to take a look.