Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Documents the suppressWarnings configuration option and how it generates per-assembly csc.rsp files to suppress specific C# compiler warnings in Unity packages.
Changes:
- Add a “Suppressing Compiler Warnings” section to the README with a
suppressWarningsexample and expectedcsc.rspoutput - Explain how suppression is applied for raw-mode (generated
.asmdef) vs unity-mode (discovered.asmdef) packages - Include a small table of common warning codes to suppress
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+255
to
+259
| The field works with all package types: | ||
|
|
||
| - **`git-raw` / `archive` (raw mode)**: `csc.rsp` is placed in `Runtime/` next to the generated `.asmdef` | ||
| - **`git-unity` / `archive` (unity mode)**: discovers all existing `.asmdef` files in the package and places a `csc.rsp` next to each one | ||
|
|
There was a problem hiding this comment.
The text says suppressWarnings works with all package types, but the implementation only generates csc.rsp for git-raw, git-unity, and archive packages (raw/unity modes). nuget packages don’t write any csc.rsp (they only extract DLLs), so this section should either exclude nuget from the claim or explicitly state that suppressWarnings is not applicable/ignored for nuget specs.
Suggested change
| The field works with all package types: | |
| - **`git-raw` / `archive` (raw mode)**: `csc.rsp` is placed in `Runtime/` next to the generated `.asmdef` | |
| - **`git-unity` / `archive` (unity mode)**: discovers all existing `.asmdef` files in the package and places a `csc.rsp` next to each one | |
| The field works with all git- and HTTP-archive-based package types: | |
| - **`git-raw` / `archive` (raw mode)**: `csc.rsp` is placed in `Runtime/` next to the generated `.asmdef` | |
| - **`git-unity` / `archive` (unity mode)**: discovers all existing `.asmdef` files in the package and places a `csc.rsp` next to each one | |
| For `nuget` package specs, `suppressWarnings` is currently ignored because the packager only extracts DLLs and does not generate any `csc.rsp` files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
suppressWarningsfield with example config and generated outputTest plan
🤖 Generated with Claude Code