Skip Unity-ignored tilde directories during package install#3
Merged
Conversation
Directories ending with ~ (Tests~, Documentation~, Samples~, etc.) are Unity's convention for ignored folders. These are now automatically excluded during package installation without needing explicit exclude patterns in the config. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the package copy/install filtering logic to automatically exclude Unity “ignored” directories whose names end with ~ (e.g., Tests~, Documentation~, Samples~) so they don’t get installed into generated packages.
Changes:
- Add a built-in skip rule in
CopyFilteredtoSkipDirfor any directory with a name ending in~. - Update
TestCopyFilteredto assert tilde directories are skipped without needing an explicit exclude pattern. - Add a new test covering multiple common Unity tilde directories with no exclude patterns.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/packager/filter.go | Adds a walk-time directory skip for Unity tilde-suffixed directories. |
| internal/packager/filter_test.go | Updates existing test and adds coverage to ensure tilde dirs are skipped by default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~(e.g.,Tests~,Documentation~,Samples~) when copying packages.gitskippingTest plan
TestCopyFiltered_SkipsTildeDirstest verifiesTests~,Documentation~,Samples~are all skippedTestCopyFilteredupdated to verify tilde dirs are skipped without explicit exclude patterns🤖 Generated with Claude Code