Add vocabulary support for facet conditions (#63)#71
Merged
Conversation
reekitconcept
force-pushed
the
63-vocab-support
branch
from
5f8c929 to
a57d23b
Compare
reekitconcept
changed the title
reekitconcept
force-pushed
the
63-vocab-support
branch
from
a57d23b to
d2f12c7
Compare
This was referenced Mar 18, 2026
reekitconcept
force-pushed
the
63-vocab-support
branch
2 times, most recently
from
19e4e7e to
7d363cc
Compare
- Add useVocab/useVocabs hooks with VocabContext for caching and batched fetching - Extend fieldList config to support vocabulary references (name, isMultilingual) - Return vocabulary metadata from backend search endpoint - Wire vocabulary labels into SearchConditions and SearchConditionsField - Hide search prefix box for vocabulary-backed facet fields - Fix useSelector rerenders in SolrSearchAutosuggest and routes - Fix livesearch widget exception during text changes - Fix test_services_navigation.py which used the wrong layer and corrupted ZODB state - Add INSTRUCTIONS.md with documentation for vocabulary support and calculated fields - Add tests for VocabContext, useVocab, useVocabs, and backend vocabulary parsing
reekitconcept
force-pushed
the
63-vocab-support
branch
from
7d363cc to
047ac98
Compare
davisagli
force-pushed
the
63-vocab-support
branch
from
5fd9839 to
4db7c10
Compare
davisagli
approved these changes
Mar 19, 2026
Member
davisagli
left a comment
davisagli
left a comment
There was a problem hiding this comment.
Basically looks good, and I tested it successfully in kitconcept.intranet.
I'll leave a few comments but it's nothing to block merging.
|
|
||
| ## Why? | ||
|
|
||
| We want to keep the documentation simple and easy to read. We want to avoid the complexity of Sphinx documentation, the Makefile, and the build process. |
Member
There was a problem hiding this comment.
You haven't gotten rid of those things though. So now we have:
- some docs in the top-level README.md
- some Sphinx docs in the docs folder
- some docs here
It's an increase in complexity unless you move the existing docs here too, no?
|
|
||
| ```xml | ||
| <field name="location_reference" type="string" indexed="true" stored="true" /> | ||
| ``` |
Member
There was a problem hiding this comment.
Users of the kitconcept/solr Docker image don't have access to schema.xml.
| <field name="location_reference" type="string" indexed="true" stored="true" /> | ||
| ``` | ||
|
|
||
| For facet fields, use `string` type to ensure exact value matching. Use `stored="true"` so the field is returned in search results, and `indexed="true"` so Solr can filter on it. |
Member
There was a problem hiding this comment.
stored=true is also necessary so that the value isn't lost when collective.solr does atomic reindexing operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.