Skip to content

新增 tgz压缩格式#742

Open
gaoxingzaq wants to merge 1 commit intokekingcn:masterfrom
gaoxingzaq:tgz
Open

新增 tgz压缩格式#742
gaoxingzaq wants to merge 1 commit intokekingcn:masterfrom
gaoxingzaq:tgz

Conversation

@gaoxingzaq
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@klboke klboke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

发现两个问题:

  1. [中] server/src/main/java/cn/keking/model/FileType.java:41 只把 tgz 加进了映射表,但文件类型判断仍然只取最后一个后缀(FileType.java:143server/src/main/java/cn/keking/utils/KkFileUtils.java:166)。这意味着常见的 *.tar.gz 仍然会被识别成 gz 并走 OTHER 分支,用户只有把文件名改成 *.tgz 才能命中这次新增逻辑。如果目标是支持 gzip 压缩的 tar 包,而不是只支持一个别名后缀,这个实现还不完整。

  2. [低] 这次改动改变了 tgz 的路由行为,但现有 E2E 仍把“未支持”当成通过条件:tests/e2e/specs/preview-smoke.spec.ts:138 允许返回 系统暂不支持在线预览。所以即使 PR 合入后 sample.tgz 仍然落到 fallback 页面,CI 也不会报错。建议把用例收紧到必须成功进入压缩包预览页。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants