Skip to content

Bump eslint-plugin-react from 7.35.0 to 7.36.1#1

Closed
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/npm_and_yarn/eslint-plugin-react-7.36.1
Closed

Bump eslint-plugin-react from 7.35.0 to 7.36.1#1
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/npm_and_yarn/eslint-plugin-react-7.36.1

Conversation

@dependabot
Copy link
Copy Markdown

@dependabot dependabot Bot commented on behalf of github Sep 16, 2024

Bumps eslint-plugin-react from 7.35.0 to 7.36.1.

Release notes

Sourced from eslint-plugin-react's releases.

v7.36.1

Fixed

#3823: jsx-eslint/eslint-plugin-react#3823 #3821: jsx-eslint/eslint-plugin-react#3821

v7.36.0

Added

Fixed

Changed

#3799: jsx-eslint/eslint-plugin-react#3799 #3632: jsx-eslint/eslint-plugin-react#3632 #3812: jsx-eslint/eslint-plugin-react#3812 #3731: jsx-eslint/eslint-plugin-react#3731 #3694: jsx-eslint/eslint-plugin-react#3667 #3629: jsx-eslint/eslint-plugin-react#3629 #3817: jsx-eslint/eslint-plugin-react#3817 #3807: jsx-eslint/eslint-plugin-react#3807

... (truncated)

Changelog

Sourced from eslint-plugin-react's changelog.

7.36.1 - 2024.09.12

Fixed

#3823: jsx-eslint/eslint-plugin-react#3823 #3821: jsx-eslint/eslint-plugin-react#3821

7.36.0 - 2024.09.12

Added

Fixed

  • [function-component-definition], [boolean-prop-naming], [jsx-first-prop-new-line], [jsx-props-no-multi-spaces], propTypes: use type args (#3629[] @​HenryBrown0)
  • JSX pragma: fail gracefully (#3632[] @​ljharb)
  • [jsx-props-no-spreading]: add explicitSpread option to schema (#3799[] @​ljharb)

Changed

#3799: jsx-eslint/eslint-plugin-react#3799 #3632: jsx-eslint/eslint-plugin-react#3632 #3812: jsx-eslint/eslint-plugin-react#3812 #3731: jsx-eslint/eslint-plugin-react#3731 #3694: jsx-eslint/eslint-plugin-react#3667 #3629: jsx-eslint/eslint-plugin-react#3629 #3817: jsx-eslint/eslint-plugin-react#3817 #3807: jsx-eslint/eslint-plugin-react#3807

7.35.2 - 2024.09.03

Fixed

  • [jsx-curly-brace-presence]: avoid autofixing attributes with double quotes to a double quoted attribute (#3814[] @​ljharb)

#3814: jsx-eslint/eslint-plugin-react#3814

[7.35.1] - 2024.09.02

Fixed

... (truncated)

Commits
  • 59ef14c Update CHANGELOG and bump version
  • 99e15e1 [Fix] jsx-no-literals: Avoid crashing on valueless boolean props
  • a09083b [Fix] no-is-mounted: fix logic in method name check
  • 1df23d2 [actions] fix release script
  • b918f02 [meta] add missing rule link
  • f25251f Update CHANGELOG and bump version
  • ceb73fe [New] add forward-ref-uses-ref rule for checking ref parameter
  • ed64b24 [Fix] jsx-props-no-spreading: add explicitSpread option to schema
  • f435df9 [Tests] button-has-type: add test case with spread
  • 0a8092f [types] add jsdoc type annotations
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot Bot added the dependencies Pull requests that update a dependency file label Sep 16, 2024
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. We will check and reply to you as soon as possible.

Bumps [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) from 7.35.0 to 7.36.1.
- [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases)
- [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md)
- [Commits](jsx-eslint/eslint-plugin-react@v7.35.0...v7.36.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-react
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/eslint-plugin-react-7.36.1 branch from 1b493a6 to 8d03ad0 Compare September 17, 2024 01:56
@dependabot @github
Copy link
Copy Markdown
Author

dependabot Bot commented on behalf of github Sep 30, 2024

Superseded by #10.

@dependabot dependabot Bot closed this Sep 30, 2024
@dependabot dependabot Bot deleted the dependabot/npm_and_yarn/eslint-plugin-react-7.36.1 branch September 30, 2024 01:36
BitHighlander added a commit that referenced this pull request Apr 30, 2026
… failover (#60)

* fix(audit): UTXO build race + cross-chain broadcast resilience + read failover

Addresses the eight remaining audit findings from PR #59's review.

P1 — UTXO build-then-approval race (#1) and broadcast resilience (#2):
- bitcoin/dogecoin/litecoin/bitcoincash/dash all awaited buildTx() fire-and-forget then created the approval event afterwards. Race produced phantom approvals (response.unsignedTx undefined) or null storedEvent depending on timing. Now buildTx is awaited BEFORE addEvent, with unsignedTx attached to the event from the start. Also applied to thorchain/cosmos/maya/osmosis/ripple — they already awaited the build but used raw fetch() without timeout/retry.
- Both build and broadcast now go through fetchJsonWithTimeout with 15s budget + 1 retry on 5xx.

P2 — cross-cutting resilience:
- New chrome-extension/src/background/fetchUtils.ts with fetchJsonWithTimeout + fetchWithTimeout. Applied to all six Pioneer endpoints in index.ts (portfolio, insight, nodes, tokens/metadata, tokens/custom GET/POST/DELETE, tokens/balances) and the UTXO/Tendermint chain handlers above.
- New chrome-extension/src/background/chains/rpcFailover.ts with withRpcFailoverByNetworkId. Iterates user-override → Pioneer → last-resort with transient/definitive classification and per-attempt transport timeout. Applied to GET_ASSET_BALANCE, GET_EVM_BALANCE, VALIDATE_ERC20_TOKEN.
- Drop check binds to the URL that accepted the broadcast — querying a different RPC could produce false-positive drop warnings, especially after a last-resort fallback succeeded. dropCheckUrlByHash maps hash → success URL; performDropCheck queries that exact URL with a 4s timeout, falling back to getProvider only on service-worker restart.
- Solana broadcastTransaction iterates SOLANA_RPC_URLS on transient failures (rate limit, 5xx, timeout). Definitive errors (insufficient funds, blockhash expired, signature verification, account-in-use) skip the loop. Cached health-checked URL is invalidated on failure so the next caller re-tests.
- Tron tronGridPost (injected bundle, can't import fetchUtils) gets inline timeout + one retry on 5xx. Broadcast paths get a longer 12s budget; reads stay at 8s.
- Health poll (checkKeepKey) gets AbortSignal.timeout(3000) + a singleflight guard so a stalled localhost:1646 can't stack overlapping probes every 5s.

Out of scope: fetchBalances per-chain RPC enrichment (line 500) still uses a single makeStaticProvider per chain since it's already inside a chain-iteration loop; further failover there would be over-engineering. GET_GAS_ESTIMATE (line 909) still uses the active provider directly — could be migrated to withRpcFailover later.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(review): Solana classifier + Bitcoin fall-through

Two findings from PR #60's review.

P1: Solana broadcast classifier was over-eager about definitive errors.
- 'already processed' is treated as success — the tx is in mempool / processed somewhere; the dApp still needs the signature. Recover it from the signed bytes (first 64-byte sig in the signed-tx layout IS the canonical Solana transaction signature). Inline base58 encoder added; reuses the existing BASE58_ALPHABET const that base58Decode already declared.
- 'blockhash not found' demoted from definitive to transient — can be RPC freshness for dApp-supplied transactions; trying the next URL is worth it. 'block height exceeded' stays definitive (the blockhash window has truly closed).
- 'account in use' demoted to transient — usually a parallel-write race that can resolve on the next URL.

P2: bitcoinHandler's broadcast catch logged + sent transaction_error but didn't re-throw, so the case 'transfer' fell through to default and returned 'Method transfer not supported' to the dApp instead of the real broadcast error. Other UTXO/Tendermint handlers don't have this catch — only bitcoin.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants