[Ruby][from_hash] Handle nilable Symbol conversion#205
Merged
Conversation
Extract _unwrap_nilable helper to deduplicate nilable type unwrapping across Symbol and Array handling in _convert_value. 🤖 Generated with the help of Claude Code. This commit message was generated by AI, but the user has most likely reviewed all of the code changes. Co-Authored-By: Claude <noreply@anthropic.com>
juharris
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
T.nilable(Symbol)properties not being converted from String to Symbol duringfrom_hash_unwrap_nilablehelper to deduplicate nilable type unwrapping across Symbol and Array handling in_convert_valuetest_symbolandtest_nilable_symboltests forSymbolandT.nilable(Symbol)property typesDetails
The
_convert_valuemethod checked forSymboltype before unwrappingT.nilable(...), soT.nilable(Symbol)properties were silently left as Strings. Now nilable is unwrapped once at the top of the method and reused for both the Symbol check and the Array inner type extraction, removing a duplicateunwrap_nilablecall.🤖 Generated with the help of Claude Code. This pull request description and possibly the code was generated by AI, but the user has most likely reviewed all of the code changes.