Add sheet_names and extend multi_extract to extract sheet by name#136
Open
Munksgaard wants to merge 1 commit intojsonkenl:masterfrom
Open
Add sheet_names and extend multi_extract to extract sheet by name#136Munksgaard wants to merge 1 commit intojsonkenl:masterfrom
sheet_names and extend multi_extract to extract sheet by name#136Munksgaard wants to merge 1 commit intojsonkenl:masterfrom
Conversation
This PR adds a new top-level function called `sheet_names` which returns the names of the sheets in the given xlsx file. It also adds support for extracting specific sheets from a xlsx file by passing in the name of the sheet to `multi_extract`. To support this functionality, a couple of new entries are added to the ets table, to allow looking up all the sheet names and mapping a sheet name to the relationship id. Much of the functionality to support looking up specific sheets by their name was already present in the code, it just needed to be exposed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new top-level function called
sheet_nameswhich returns the names of the sheets in the given xlsx file. It also adds support for extracting specific sheets from a xlsx file by passing in the name of the sheet tomulti_extract.To support this functionality, a couple of new entries are added to the ets table, to allow looking up all the sheet names and mapping a sheet name to the relationship id.
Much of the functionality to support looking up specific sheets by their name was already present in the code, it just needed to be exposed.