Adding 5-8 for Excel non-standard currency formats#116
Open
jbosse wants to merge 4 commits intojsonkenl:masterfrom
Open
Adding 5-8 for Excel non-standard currency formats#116jbosse wants to merge 4 commits intojsonkenl:masterfrom
jbosse wants to merge 4 commits intojsonkenl:masterfrom
Conversation
jbosse
changed the title
jbosse
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excel correctly exports the
numFmtnodes for 5-8 when saving from excel, however it will gladly open and correctly render a file that is missing thenumFmtnodes but references theirnumFmtIdin thecellXfsnode.Specifically I am working with a file from the Axlsx gem that is not correctly adding
numFmtnodes for these Excel specific values. And trying to import these files raises and exception. While I am going to also submit a PR on that repo to correct the issue, I think it is safe to assume 5-8 are numbers since Excel assumes those formats.