Open
Conversation
Author
|
Hi @jonhoo Please review this pr. |
Contributor
|
I personally welcome this change, but I think this is a breaking change (for callers that also interact directly with rustls), so probably the msql-srv version in Cargo.toml needs bumping? |
Author
I see tokio-rustls it use ring feature. |
Owner
|
Since I don't use this crate any more myself, I'm ending up with very little time to actually devote to its upkeep. If either of you are actively using it, would you be interested in stepping up to maintaining it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggest bump, in databend ci:
cargo audit --db ./target/advisory-db
==> build-tool using image runner/build-tool:dev-nightly-2024-07-02
Fetching advisory database from
[https://github.com/RustSec/advisory-db.git](https://github.com/RustSec/advisory-db.git%60)Loaded 688 security advisories (from ./target/advisory-db)
Updating crates.io index
Scanning Cargo.lock for vulnerabilities (1349 crate dependencies)
Crate: rustls
Version: 0.22.4
Title: rustls network-reachable panic in
Acceptor::acceptDate: 2024-11-22
ID: RUSTSEC-2024-0399
URL: https://rustsec.org/advisories/RUSTSEC-2024-0399
Solution: Upgrade to >=0.23.18
Dependency tree:
rustls 0.22.4
├── tokio-rustls 0.25.0
│ └── opensrv-mysql 0.7.0
│ └── databend-query 0.1.0
│ ├── databend-enterprise-query 0.1.0
│ │ └── databend-binaries 0.1.0
│ └── databend-binaries 0.1.0
├── msql-srv 0.11.0
│ └── databend-sqllogictests 0.1.0
└── databend-query 0.1.0