Support CLIENT_PLUGIN_AUTH for mysql_native_password over tls#68
Open
lanklaas wants to merge 11 commits intojonhoo:mainfrom
Open
Support CLIENT_PLUGIN_AUTH for mysql_native_password over tls#68lanklaas wants to merge 11 commits intojonhoo:mainfrom
lanklaas wants to merge 11 commits intojonhoo:mainfrom
Conversation
added 11 commits
October 24, 2024 05:44
This adds support for CLIENT_PLUGIN_AUTH only when tls is enabled. This is because the default that is implemented here is mysql_native_password and this auth method is no longer secure.
Forgot to add this check back from main. If this check does not happen then the client get unexpected eof
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used some of the code in the open PR and tried to resolve as many of your comments on that PR in this one.
Main
This adds support for username password authentication over tls only. If tls is not enabled or configured password auth will not be advertised.
Additional
mysql-connector-j-8.2.0)mysql_commonandrustls