Skip to content

printsize (fix): swap const width and height for A4#297

Merged
jonhoo merged 2 commits intojonhoo:mainfrom
Aprax14:a4-dimensions-fix
Jun 14, 2025
Merged

printsize (fix): swap const width and height for A4#297
jonhoo merged 2 commits intojonhoo:mainfrom
Aprax14:a4-dimensions-fix

Conversation

@Aprax14
Copy link
Copy Markdown
Contributor

@Aprax14 Aprax14 commented Apr 14, 2025

This fixes the A4 paper size const definition in the printsize struct, where the width and height values were inverted

@paolobarbolini
Copy link
Copy Markdown
Contributor

@jonhoo I see things are stalled in the other PRs. We'd like to start using #285 + the fix in this PR. Could we make a new release with this merged and leave everything else to the future?

Copy link
Copy Markdown
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@jonhoo
Copy link
Copy Markdown
Owner

jonhoo commented Jun 14, 2025

@paolobarbolini Release coming up 👍

Comment thread src/print.rs Outdated
@jonhoo jonhoo merged commit 696879a into jonhoo:main Jun 14, 2025
18 of 20 checks passed
@jonhoo
Copy link
Copy Markdown
Owner

jonhoo commented Jun 14, 2025

Released as 0.22.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants