Skip to content

cargo update#294

Merged
jonhoo merged 9 commits intomainfrom
bump
Jun 14, 2025
Merged

cargo update#294
jonhoo merged 9 commits intomainfrom
bump

Conversation

@jonhoo
Copy link
Copy Markdown
Owner

@jonhoo jonhoo commented Mar 22, 2025

Breaking change because the webdriver crate now generates floating point numbers for pointer move operations, which are rejected by older versions of Chrome and Firefox. See https://bugzilla.mozilla.org/show_bug.cgi?id=1959464 for details.

@jonhoo
Copy link
Copy Markdown
Owner Author

jonhoo commented Mar 22, 2025

This currently fails because the webdriver crate failed to make the capabilities field of NewSessionParameters pub when converting it from an enum to a struct as part of the removal of legacy support in 0.51. I've reported it to the mailing list, but we'll be blocked from upgrading until a fix lands.

@jonhoo
Copy link
Copy Markdown
Owner Author

jonhoo commented Mar 22, 2025

The email doesn't appear to have gone through, so I've commented on the relevant upstream change.

@jonhoo
Copy link
Copy Markdown
Owner Author

jonhoo commented Mar 24, 2025

Upstream bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1955903

@jonhoo
Copy link
Copy Markdown
Owner Author

jonhoo commented Mar 29, 2025

Worth noting that this will be a breaking change, but that's okay since we'll already have to break with #289 and #285.

@jonhoo
Copy link
Copy Markdown
Owner Author

jonhoo commented Mar 29, 2025

Well this is awkward: the current versions of Firefox and Chrome both only allow integer values for the x and y fields of pointer action move commands, but webdriver now encodes them as f64. I have followed up upstream in the same bug report.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 14, 2025

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 66.57%. Comparing base (c5c6a9d) to head (4dbe23e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/client.rs 57.14% 3 Missing ⚠️
src/elements.rs 50.00% 2 Missing ⚠️
src/session.rs 88.88% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/actions.rs 58.33% <ø> (ø)
src/elements.rs 57.60% <50.00%> (+0.23%) ⬆️
src/session.rs 84.26% <88.88%> (+8.34%) ⬆️
src/client.rs 63.80% <57.14%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonhoo
Copy link
Copy Markdown
Owner Author

jonhoo commented Jun 14, 2025

minimal-versions in CI will remain broken until webdriver upgrades to a newer version of icu_segmenter (specifically: 2.0) so that they move on from the zerovec version that has this stanza: https://github.com/unicode-org/icu4x/blob/icu%401.5.0/utils/zerovec/Cargo.toml#L33-L38

Updates all dependencies to latest major version. This includes the
webdriver crate, which now generates floating point numbers for pointer
move operations. These are in turn rejected by older versions of Chrome
and Firefox. See https://bugzilla.mozilla.org/show_bug.cgi?id=1959464
for details. As such, this is breaking in the sense that older versions
of said browsers are no longer supported.

This also bumps the crate's MSRV, but only due to dependencies, not code
changes.

Note that minimal-versions in CI will remain broken until webdriver
upgrades to a newer version of icu_segmenter (specifically: 2.0) so that
they move on from the zerovec version that has this stanza:
<https://github.com/unicode-org/icu4x/blob/icu%401.5.0/utils/zerovec/Cargo.toml#L33-L38>
@jonhoo jonhoo merged commit a2457c7 into main Jun 14, 2025
17 of 18 checks passed
@jonhoo jonhoo deleted the bump branch June 14, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant