test(grpcdynamic): added negative test cases for invalid message types#643
test(grpcdynamic): added negative test cases for invalid message types#643Aaditya-ops-cpu wants to merge 1 commit intojhump:mainfrom
Conversation
|
@Aaditya-ops-cpu, thanks for the pull request, but these tests aren't particularly valuable. The "needs more tests" remark in the README is referring to the fact that new functionality in V2 doesn't yet have adequate test coverage. The The main place remaining that still needs more test is the Also, if you want to contribute in the future, please run |
|
@jhump Thanks for the clarification sir 👍. I misunderstood the README. I’ll take a look at adding tests around protoresolve instead and will make sure to run make ci locally for future contributions 👍. |
This PR adds negative test cases to grpcdynamic to verify that InvokeRpc and InvokeRpcClientStream correctly return an error when provided with a message type that does not match the method descriptor and this matches the "needs more tests" note in the README regarding new V2 functionality. 👍😊