Add html id to headers so that you can link to specific headers in the markdown.#55
Open
markcho wants to merge 1 commit intojfernandez:mainfrom
Open
Add html id to headers so that you can link to specific headers in the markdown.#55markcho wants to merge 1 commit intojfernandez:mainfrom
markcho wants to merge 1 commit intojfernandez:mainfrom
Conversation
jfernandez
requested changes
Feb 7, 2026
Owner
jfernandez
left a comment
There was a problem hiding this comment.
Good feature. Main ask: drop the regex dependency. Since markdown-rs produces clean HTML (no attributes on headings), this can be done with str::find for the heading tags and a simple char iterator to strip inner HTML. That avoids pulling in aho-corasick, regex-automata, and regex-syntax for two simple patterns.
4d5018c to
1808c95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, generated html doesn't include any anchors or ids on the header.
This PR uses the Github-style slugs for header ids so that links to headers now work. This is useful for things like table of contents at the top.