Skip to content

Minor cleanup after disco secrets work #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SgtCoDFish merged 3 commits into from
Mar 5, 2026
Merged

Minor cleanup after disco secrets work #785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9fb661
remove outdated references to deleted example
SgtCoDFish Mar 5, 2026
c50ba7b
update release docs to remove reference to old team member
SgtCoDFish Mar 5, 2026
718fbf3
remove reference to venctl, update wording
SgtCoDFish Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,3 @@ predicate.json

_bin
.envrc

examples/encrypted-secrets/output.json
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ go run . agent \
> - [./agent.yaml](./agent.yaml).
> - [./examples/one-shot-secret.yaml](./examples/one-shot-secret.yaml).
> - [./examples/cert-manager-agent.yaml](./examples/cert-manager-agent.yaml).
> - [./examples/encrypted-secrets](./examples/encrypted-secrets) - Send encrypted Kubernetes secrets to CyberArk.

You might also want to run a local echo server to monitor requests sent by the agent:

Expand Down
11 changes: 6 additions & 5 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# Release Process

> [!NOTE]
> Before starting, let Michael McLoughlin know that a release is about to be created so that documentation can be prepared in advance.
> Before starting a release let the docs team know that a release is about to be created so that documentation can be prepared in advance.
> This is not necessary for pre-releases.

The release process is semi-automated.

Expand Down Expand Up @@ -63,11 +64,11 @@ The release process is semi-automated.

7. Publish the release.

8. Inform the `#venctl` channel that a new version of Discovery Agent has been
released. Make sure to share any breaking change that may affect `venctl connect`
or `venctl generate`.
8. Inform the `#venafi-kubernetes-agent` channel on Slack that a new version of the Venafi Discovery Agent has been
released (and that a new version of the disco-agent has been released!)a
TODO: Who should be notified on the disco side?

9. Inform Michael McLoughlin of the new release so he can update the
9. Inform the docs team of the new release so they can update the
documentation at <https://docs.cyberark.com/>.

[tests-workflow]: https://github.com/jetstack/jetstack-secure/actions/workflows/tests.yaml?query=branch%3Amaster
Expand Down