Skip to content

remove ms_teams#1757

Merged
jertel merged 2 commits intojertel:masterfrom
nsano-rururu:remove_msteams
Apr 5, 2026
Merged

remove ms_teams#1757
jertel merged 2 commits intojertel:masterfrom
nsano-rururu:remove_msteams

Conversation

@nsano-rururu
Copy link
Copy Markdown
Collaborator

@nsano-rururu nsano-rururu commented Apr 5, 2026

Description

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

Copilot AI review requested due to automatic review settings April 5, 2026 06:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the built-in Microsoft Teams (ms_teams) alerter from ElastAlert 2, including its implementation, schema entries, tests, and user-facing documentation references.

Changes:

  • Deleted the MsTeamsAlerter implementation and its unit tests.
  • Removed ms_teams from rule loading/alert type mapping and from the rule schema.
  • Updated docs to no longer list/document Microsoft Teams as a supported alert type.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/alerters/teams_test.py Removes unit tests for the MS Teams alerter.
elastalert/schema.yaml Drops MS Teams-specific schema definitions and rule properties.
elastalert/loaders.py Removes ms_teams from the built-in alerts_mapping.
elastalert/alerters/teams.py Deletes the MS Teams alerter implementation.
docs/source/elastalert.rst Removes Microsoft Teams from the supported alert types list.
docs/source/alerts.rst Removes ms_teams from alert type lists and deletes the MS Teams documentation section.
Comments suppressed due to low confidence (2)

docs/source/elastalert.rst:60

  • This PR removes built-in Microsoft Teams alerting, which is a breaking change for existing ms_teams rules. The alert-type list has been updated here, but the CHANGELOG still contains MS Teams entries and doesn’t note the removal; please add a Breaking Changes entry describing the removal and the recommended replacement (e.g., ms_power_automate).
- LINE Messaging API
- Matrix Hookshot
- Mattermost
- Microsoft Power Automate
- OpsGenie
- PagerDuty
- PagerTree

docs/source/alerts.rst:1638

  • With the Microsoft Teams section removed, readers landing in this area of the alerts docs won’t see an explanation of what happened to the ms_teams alert type. Consider adding a short note (near this transition) that ms_teams has been removed and point to the supported alternative (ms_power_automate) to reduce confusion for users upgrading.

Microsoft Power Automate
~~~~~~~~~~~~~~~~~~~~~~~~

Microsoft Power Automate alerter will send a notification to a predefined Microsoft Teams channel.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 116 to 120
'command': elastalert.alerters.command.CommandAlerter,
'sns': SnsAlerter,
'sqs': SqsAlerter,
'ms_teams': MsTeamsAlerter,
'ms_power_automate': MsPowerAutomateAlerter,
'slack': SlackAlerter,
Copy link

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the ms_teams entry from alerts_mapping means existing rules will now fall back to get_module('ms_teams'), which will likely fail with an ImportError-style message that doesn’t clearly explain that the built-in MS Teams alerter was removed. Consider adding an explicit guard (e.g., special-casing ms_teams in create_alert) to raise an EAException with a clear migration hint (like using ms_power_automate).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an outdated alerter remaining, and I had previously received inquiries about it not working, so I advised using the newer alerter. Therefore, I will be deleting it.

@jertel jertel merged commit 9f8f3a8 into jertel:master Apr 5, 2026
1 check passed
@jertel
Copy link
Copy Markdown
Owner

jertel commented Apr 5, 2026

Thanks for removing it. The EOL has been extended through end of this month, but I see no reason to wait.

@nsano-rururu nsano-rururu deleted the remove_msteams branch April 5, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants