Conversation
There was a problem hiding this comment.
Pull request overview
Removes the built-in Microsoft Teams (ms_teams) alerter from ElastAlert 2, including its implementation, schema entries, tests, and user-facing documentation references.
Changes:
- Deleted the
MsTeamsAlerterimplementation and its unit tests. - Removed
ms_teamsfrom rule loading/alert type mapping and from the rule schema. - Updated docs to no longer list/document Microsoft Teams as a supported alert type.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tests/alerters/teams_test.py |
Removes unit tests for the MS Teams alerter. |
elastalert/schema.yaml |
Drops MS Teams-specific schema definitions and rule properties. |
elastalert/loaders.py |
Removes ms_teams from the built-in alerts_mapping. |
elastalert/alerters/teams.py |
Deletes the MS Teams alerter implementation. |
docs/source/elastalert.rst |
Removes Microsoft Teams from the supported alert types list. |
docs/source/alerts.rst |
Removes ms_teams from alert type lists and deletes the MS Teams documentation section. |
Comments suppressed due to low confidence (2)
docs/source/elastalert.rst:60
- This PR removes built-in Microsoft Teams alerting, which is a breaking change for existing
ms_teamsrules. The alert-type list has been updated here, but the CHANGELOG still contains MS Teams entries and doesn’t note the removal; please add a Breaking Changes entry describing the removal and the recommended replacement (e.g.,ms_power_automate).
- LINE Messaging API
- Matrix Hookshot
- Mattermost
- Microsoft Power Automate
- OpsGenie
- PagerDuty
- PagerTree
docs/source/alerts.rst:1638
- With the Microsoft Teams section removed, readers landing in this area of the alerts docs won’t see an explanation of what happened to the
ms_teamsalert type. Consider adding a short note (near this transition) thatms_teamshas been removed and point to the supported alternative (ms_power_automate) to reduce confusion for users upgrading.
Microsoft Power Automate
~~~~~~~~~~~~~~~~~~~~~~~~
Microsoft Power Automate alerter will send a notification to a predefined Microsoft Teams channel.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 'command': elastalert.alerters.command.CommandAlerter, | ||
| 'sns': SnsAlerter, | ||
| 'sqs': SqsAlerter, | ||
| 'ms_teams': MsTeamsAlerter, | ||
| 'ms_power_automate': MsPowerAutomateAlerter, | ||
| 'slack': SlackAlerter, |
There was a problem hiding this comment.
Removing the ms_teams entry from alerts_mapping means existing rules will now fall back to get_module('ms_teams'), which will likely fail with an ImportError-style message that doesn’t clearly explain that the built-in MS Teams alerter was removed. Consider adding an explicit guard (e.g., special-casing ms_teams in create_alert) to raise an EAException with a clear migration hint (like using ms_power_automate).
There was a problem hiding this comment.
There was an outdated alerter remaining, and I had previously received inquiries about it not working, so I advised using the newer alerter. Therefore, I will be deleting it.
|
Thanks for removing it. The EOL has been extended through end of this month, but I see no reason to wait. |
Description
Checklist
make test-dockerwith my changes.Questions or Comments