feat: add SendEnv SSH configuration support#241
Open
vitorpy wants to merge 1 commit intojeanp413:masterfrom
Open
feat: add SendEnv SSH configuration support#241vitorpy wants to merge 1 commit intojeanp413:masterfrom
vitorpy wants to merge 1 commit intojeanp413:masterfrom
Conversation
Implements SendEnv directive parsing and environment variable forwarding to remote hosts, matching OpenSSH behavior. Features: - Parse SendEnv directives from SSH config files - Support wildcard patterns (e.g., LC_*, LANG) - Filter and export local environment variables to remote - Cross-platform support (Linux, macOS, Windows) - Graceful degradation when remote doesn't accept env vars Implementation: - Added SendEnv to SSH_CONFIG_PROPERTIES in sshConfig.ts - Created glob-to-regex pattern matching in authResolver.ts - Modified server installation scripts to export env vars - Added comprehensive logging for debugging The feature assumes AcceptEnv is configured on the remote SSH server. Environment variables are exported in the remote shell before starting the VSCode server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements SendEnv directive parsing and environment variable forwarding to remote hosts, matching OpenSSH behavior.
Features
LC_*,LANG)Implementation Details
Files Modified
src/ssh/sshConfig.ts'sendenv': 'SendEnv'toSSH_CONFIG_PROPERTIESsrc/authResolver.tsglobToRegex(): Converts glob patterns to regexfilterEnvBySendEnv(): Filters local env vars based on patternsprocess.envsrc/serverSetup.tsServerInstallOptionsinterface withsendEnvVarsHow It Works
*,?)Example Usage
Testing
Notes
AcceptEnvis configured on the remote SSH server