Download and extract vscode-server in temp directory#196
Open
MatthewCash wants to merge 1 commit intojeanp413:masterfrom
Open
Download and extract vscode-server in temp directory#196MatthewCash wants to merge 1 commit intojeanp413:masterfrom
MatthewCash wants to merge 1 commit intojeanp413:masterfrom
Conversation
Collaborator
|
@MatthewCash It doesn't solve
Shouldn't a directory lock be used to fix that issue? |
Author
Yeah probably, I don't use this anymore so if you have a better solution I would close this in favor of yours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If either extraction is interrupted (with
$SERVER_SCRIPTat least partially-created) or multiple instances of the installation script run at the same time, the installation process becomes stuck and needs manual intervention.This fixes the issue by performing the time-consuming installation steps in a per-installation-instance temp directory and only copying the files over once extraction completes.