[WIP] Add LinkedIn button and reorder contact button row#28
Merged
jaypatrick merged 3 commits intomainfrom Apr 23, 2026
Merged
Conversation
…pacing Agent-Logs-Url: https://github.com/jaypatrick/jk.com/sessions/be18dfc4-310c-4bae-9f6a-3f9874a88d47 Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jaypatrick/jk.com/sessions/be18dfc4-310c-4bae-9f6a-3f9874a88d47 Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates site UI/navigation to improve discoverability (LinkedIn link), fix header section links when navigating from /blog, and tighten spacing + Calendly embed theming.
Changes:
- Reduced global section padding and tightened Contact section internal spacing.
- Added a LinkedIn button and reordered the Contact “Social / links” button row.
- Fixed Header nav section links to work from
/blogby using absolute/#sectionhrefs and updated active-link detection.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/styles/global.css | Reduces .section-pad vertical padding for tighter section spacing site-wide. |
| src/components/sections/Contact.svelte | Adds LinkedIn CTA, reorders buttons, tightens layout gaps, and applies dark theme params to Calendly inline widget via a shared URL constant. |
| src/components/layout/Header.svelte | Makes hash nav links absolute (/#...) and introduces isActiveLink to keep active-state styling working with the new href format and /blog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.
Original prompt
Summary
Four UI improvements based on review of the live site (screenshot attached):
1. Add LinkedIn button & reorder the contact button row (
src/components/sections/Contact.svelte)In the "Social / links"
flexrow (currently: GitHub → Book Me → Blog):btn btn-outlinebutton linking tohttps://www.linkedin.com/in/jaysonknight(or the correct LinkedIn URL — use a placeholder if unsure)2. Fix Blog nav tab — other links stop working after clicking Blog (
src/components/layout/Header.svelte)Root cause: The
navLinksarray uses relative hash hrefs (#home,#about, etc.). After navigating to/blog, clicking those hash anchors resolves to/blog#about(same page) instead of/#abouton the home page — nothing happens.Fix: Change all hash-based hrefs in
navLinksto absolute paths so they work from any route:Also update the
activeHrefcomparison logic — the scroll-based IntersectionObserver setsactiveHrefto#about,#services, etc. (without the leading/). After changing the hrefs to/#about, theactiveHref === hrefcheck will fail. Fix by either:activeHrefwith the leading slash too (e.g./#about), oractiveHrefvalues as bare hashes and comparinghref.endsWith(activeHref)or stripping the/prefix for the comparison.The cleanest approach: keep the internal activeHref as bare
#section-idfor the observer logic, and when comparing for active state do:activeHref === href || '/' + activeHref === href.3. Make the embedded Calendly widget dark (
src/components/sections/Contact.svelte)Calendly inline widgets accept theming via URL query parameters. Update both the
initInlineWidgetURL and thedata-urlattribute on the container div to include dark theme params matching the site palette:In the
$effectblock (around line 97):And update the
data-urlattribute on the container div (around line 343):4. Tighten vertical spacing — reduce large gaps between sections (
src/styles/global.css+src/components/sections/Contact.svelte)global.css— reducesection-pad:Contact.svelte— tighten the inner gaps:gap-16→gap-10on the two-column grid (line ~110)mb-10→mb-6on the intro paragraph (line ~119)mb-10→mb-6on the contact details block (line ~125)mt-16→mt-10on the Calendly section wrapper (line ~337)The following is the prior conversation context from the user's chat exploration (may be truncated):
User: - Add LinkedIn to the row of buttons including Github, Book Me, Blog. Move red book me button to the end of the row.
Assistant: Now I have everything I need. Let me create the PR with all fou...
This pull request was created from Copilot chat.