Open
Conversation
Owner
|
Thanks for picking up this can you rebase so only your commits are in the PR please? |
Owner
|
Ping? |
to a given folder instead of sending via SMTP.
cbrownstein
force-pushed
the
localMail
branch
from
67c52af to
d3d6beb
Compare
Contributor
Author
Done! |
jaymzh
requested changes
Feb 8, 2019
Owner
jaymzh
left a comment
jaymzh
left a comment
There was a problem hiding this comment.
The README still needs to give a sample command for sending these.
| os.mkdir(self.local_mail_dir) | ||
| if not self.address_override: | ||
| msg['Bcc'] = self.mail | ||
| email = open(os.path.join(self.local_mail_dir, msg['To']), 'w') |
Owner
There was a problem hiding this comment.
with open(os.path.join(self.local_mail_dir, msg['To']), 'w') as email:
email.write(str(msg))
| # Don't want to send auth information unless we're TLS'd | ||
| if self.user: | ||
| smtp.login(self.user, self.password) | ||
| if self.address_override: |
Owner
There was a problem hiding this comment.
this is no longer needed, you do it above.
| smtp.login(self.user, self.password) | ||
| if self.address_override: | ||
| env_to = self.address_override | ||
| else: |
Owner
|
ping @cbrownstein |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resumes the work done in #29
I've performed some testing (the new option seems to work) but I'd like to test more before I recommend that this PR be merged. Help testing would be appreciated! 😃