WADL: fix repeating param support#9
WADL: fix repeating param support#9mfulton26 wants to merge 1 commit intojavaee:masterfrom mfulton26:repeatedWadlParam
Conversation
Checking Class.isArray() doesn't work as Jersey params cannot be arrays. This patch replaces the pClass.isArray() check with an Iterable.class.isAssignableFrom(pClass) check and then uses the ParameterizedType (if available) to determine the wadl:type.
|
Hi Mark, Before we can review your pull request, we need you to sign Oracle Contributor Agreement. More information about contributing to Jersey: https://jersey.java.net/scm.html#/Submitting_Patches_and_Contribute_Code… Regards, |
|
Thank you @mgajdos for the comment. I have emailed a signed copy of the OCA to oracle-ca_us@oracle.com. |
|
FYI: My OCA has been reviewed and approved. |
|
@mgajdos can this be reviewed now that my OCA has been reviewed and approved? |
|
Hi Mark, Sorry that it took so long for us to review your OCA approval. I have now checked that your OCA has been approved and then reviewed the code. It looks good to me, however, we require that any bug fix comes with an associated reproducer unit test. Please feel free to update the existing WADL tests suite with a new test that reproduces the issue and verifies the fix. |
3 participants
Checking Class.isArray() doesn't work as Jersey params cannot be arrays.
This patch replaces the pClass.isArray() check with an
Iterable.class.isAssignableFrom(pClass) check and then uses the
ParameterizedType (if available) to determine the wadl:type.