[_795] allow options to be accessed as attributes of metadata obj#796
[_795] allow options to be accessed as attributes of metadata obj#796d-w-moore wants to merge 1 commit intoirods:mainfrom
Conversation
alanking
left a comment
alanking
left a comment
There was a problem hiding this comment.
Please address or explicitly ignore Ruff as you see fit.
d-w-moore
changed the title
korydraughn
left a comment
korydraughn
left a comment
There was a problem hiding this comment.
Good stuff so far.
There are a few more things being reported by ruff.
|
After some discussion, the current state of this PR is that it is working and all that's left to do is address the ruff report and code review comments. |
korydraughn
left a comment
korydraughn
left a comment
There was a problem hiding this comment.
Squash to taste if everything is working as intended.
Ok . added test. Will do the squash after I see all tests are passing |
d-w-moore
force-pushed
the
795.m
branch
2 times, most recently
from
0105116 to
b4461ac
Compare
alanking
left a comment
alanking
left a comment
There was a problem hiding this comment.
Looking good. Just had one question. Please notify when ready
|
Tests are passing. I think this is ready to squash |
|
Oh, and please remove the re-run-tests file. |
|
squashed (no more dummy file for test.) |
alanking
left a comment
alanking
left a comment
There was a problem hiding this comment.
Please adjust commit title (i.e. remove "SQUASH") and co-authorship (or leave it) as desired and we can get this in
|
Please update the commit message to not include my name/email. |
yes, will do. in the future as well, for minor README / corrections / suggestions. I think it was automatic Github or git machinery doing it. Sorry! |
d-w-moore
force-pushed
the
795.m
branch
2 times, most recently
from
8b27a1d to
66bd949
Compare
|
All good. I know the GitHub machinery automatically does that. Just want to avoid that particular email landing in iRODS commits. |
|
|
ok... removed |
3 participants
No description provided.