feat!: add support for transcoder retries#28
Merged
bajankristof merged 3 commits intomainfrom Jun 25, 2025
Merged
Conversation
kiskoza
previously approved these changes
Jun 25, 2025
kadirsaglam41
previously approved these changes
Jun 25, 2025
With this change it is now possible to define command arguments in presets, transcoders and composables that are only passed on to FFmpeg if we're currently retrying the command due to it having exited with a non-zero exit status. BREAKING CHANGES: - FFMPEG::Status::ExitError has been renamed to FFMPEG::ExitError - FFMPEG::ExitError now holds the StringIO output representation
BREAKING CHANGE: - The `FFMPEG::Transcoding::Status#success?` method now checks whether all output files have been created or not. This behaviour can be disabled by setting the `checks` keyword argument on the transcoder to an empty array (or whatever checks you wish to perform). - Transcoding retries now consider the transcoding status checks when deciding whether to retry the process or not.
bajankristof
dismissed stale reviews from kadirsaglam41 and kiskoza
The merge-base changed after approval.
kiskoza
approved these changes
Jun 25, 2025
kadirsaglam41
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.