Skip to content

feat: Add adaptive poll rate interval logic#868

Merged
CagriYonca merged 1 commit intomainfrom
poll-rate
Apr 30, 2026
Merged

feat: Add adaptive poll rate interval logic#868
CagriYonca merged 1 commit intomainfrom
poll-rate

Conversation

@CagriYonca
Copy link
Copy Markdown
Contributor

No description provided.

@CagriYonca CagriYonca self-assigned this Apr 29, 2026
@CagriYonca CagriYonca requested a review from a team as a code owner April 29, 2026 10:35
Copy link
Copy Markdown
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few requests.

One general question: does your PR impact both metrics and traces reporting?

Comment thread src/instana/options.py
Comment thread src/instana/options.py
Comment thread tests/test_options.py Outdated
Comment thread tests/test_options.py Outdated
Comment thread tests/test_options.py Outdated
@CagriYonca
Copy link
Copy Markdown
Contributor Author

A few requests.

One general question: does your PR impact both metrics and traces reporting?

Now it impacts only the metrics

@CagriYonca CagriYonca force-pushed the poll-rate branch 2 times, most recently from 5568eff to 2b1b97f Compare April 30, 2026 10:21
@CagriYonca CagriYonca requested a review from pvital April 30, 2026 10:28
Copy link
Copy Markdown
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little request you missed.

Comment thread src/instana/options.py
Signed-off-by: Cagri Yonca <cagri@ibm.com>
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@CagriYonca CagriYonca merged commit 1939958 into main Apr 30, 2026
18 checks passed
@CagriYonca CagriYonca deleted the poll-rate branch April 30, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants