fix: resolve extracted minitiad path and preserve binary permissions#207
Conversation
- Preserve executable permissions during tar extraction so `minitiad` remains runnable after download. - Make binary detection work before executable permissions are restored, then normalize permissions with `chmod`. - Add regression coverage for extracted binary discovery and permission preservation. - Validate the MiniEVM `weave init` flow on both Linux and macOS.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughFindBinaryDir now matches target executables by filename only (removes executable-permission check). ExtractTarGz was hardened: destination resolved to absolute, archive entry paths are validated against path traversal, parent directories are created, files are created with header modes and then chmod'd; tests updated/added accordingly. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
minitiadremains runnable after download.chmod.weave initflow on both Linux and macOS.Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
I have...
!in the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
Bug Fixes
Tests