Skip to content

ci: test#723

Closed
NguyenHoangSon96 wants to merge 19 commits intomasterfrom
ci/test2
Closed

ci: test#723
NguyenHoangSon96 wants to merge 19 commits intomasterfrom
ci/test2

Conversation

@NguyenHoangSon96
Copy link
Copy Markdown
Contributor

Closes #

Proposed Changes

Briefly describe your proposed changes:

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Mar 10, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CircleCI snapshot deployment behavior and adjusts how NuGet packages are packed/versioned during the “deploy preview” job.

Changes:

  • Switches snapshot packing to explicit .csproj paths with an explicit Version value for several packages.
  • Adjusts CircleCI deploy step formatting and removes the branch-only filter for the deploy-preview job.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
Scripts/ci-deploy-snapshot.sh Changes dotnet pack commands to use explicit project paths and hard-coded versioning; adds additional pack invocations.
.circleci/config.yml Modifies deploy command formatting and comments out branch filters for deploy-preview.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Scripts/ci-deploy-snapshot.sh Outdated
Comment on lines +14 to +17
dotnet pack Client.Core/Client.Core.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM
dotnet pack Client.Legacy/Client.Legacy.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM
dotnet pack Client.Linq/Client.Linq.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM
dotnet pack Client/Client.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snapshot version is hard-coded to 5.1.0 here. Since project files already define VersionPrefix/VersionSuffix, this will drift the next time the version is bumped and CI will publish mismatched versions. Consider using --version-suffix=dev.$CIRCLE_BUILD_NUM (or -p:VersionSuffix=...) while pointing at the .csproj, rather than setting an explicit Version value in the script.

Suggested change
dotnet pack Client.Core/Client.Core.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM
dotnet pack Client.Legacy/Client.Legacy.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM
dotnet pack Client.Linq/Client.Linq.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM
dotnet pack Client/Client.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM
dotnet pack Client.Core/Client.Core.csproj -c Debug -p:VersionSuffix=dev.$CIRCLE_BUILD_NUM
dotnet pack Client.Legacy/Client.Legacy.csproj -c Debug -p:VersionSuffix=dev.$CIRCLE_BUILD_NUM
dotnet pack Client.Linq/Client.Linq.csproj -c Debug -p:VersionSuffix=dev.$CIRCLE_BUILD_NUM
dotnet pack Client/Client.csproj -c Debug -p:VersionSuffix=dev.$CIRCLE_BUILD_NUM

Copilot uses AI. Check for mistakes.
Comment thread Scripts/ci-deploy-snapshot.sh Outdated
Comment on lines +17 to +20
dotnet pack Client/Client.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM

dotnet pack Client --version-suffix=dev.$CIRCLE_BUILD_NUM
dotnet pack Client.Linq --version-suffix=dev.$CIRCLE_BUILD_NUM

Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InfluxDB.Client is being packed twice (once via Client/Client.csproj and again via dotnet pack Client). This adds CI time and can lead to confusing build outputs (same package/version generated multiple times). Keep only one pack invocation for the Client package and make sure it uses the same versioning approach as the others.

Copilot uses AI. Check for mistakes.
Comment thread .circleci/config.yml
Comment on lines +245 to +247
# filters:
# branches:
# only: master
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deploy-preview job no longer has a branch filter (it was previously restricted to master). With this change, any branch build on the main influxdata org repo will publish snapshot packages, which is a significant operational risk (unexpected package churn/overwrites). Please restore an appropriate branch filter or add an explicit conditional guard before publishing.

Suggested change
# filters:
# branches:
# only: master
filters:
branches:
only: master

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Scripts/ci-deploy-snapshot.sh Outdated
Comment thread Scripts/ci-deploy-snapshot.sh Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .circleci/config.yml Outdated
@NguyenHoangSon96 NguyenHoangSon96 deleted the ci/test2 branch March 10, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants