Conversation
There was a problem hiding this comment.
Pull request overview
Updates CircleCI snapshot deployment behavior and adjusts how NuGet packages are packed/versioned during the “deploy preview” job.
Changes:
- Switches snapshot packing to explicit
.csprojpaths with an explicitVersionvalue for several packages. - Adjusts CircleCI deploy step formatting and removes the branch-only filter for the
deploy-previewjob.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Scripts/ci-deploy-snapshot.sh | Changes dotnet pack commands to use explicit project paths and hard-coded versioning; adds additional pack invocations. |
| .circleci/config.yml | Modifies deploy command formatting and comments out branch filters for deploy-preview. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| dotnet pack Client.Core/Client.Core.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM | ||
| dotnet pack Client.Legacy/Client.Legacy.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM | ||
| dotnet pack Client.Linq/Client.Linq.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM | ||
| dotnet pack Client/Client.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM |
There was a problem hiding this comment.
The snapshot version is hard-coded to 5.1.0 here. Since project files already define VersionPrefix/VersionSuffix, this will drift the next time the version is bumped and CI will publish mismatched versions. Consider using --version-suffix=dev.$CIRCLE_BUILD_NUM (or -p:VersionSuffix=...) while pointing at the .csproj, rather than setting an explicit Version value in the script.
| dotnet pack Client.Core/Client.Core.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM | |
| dotnet pack Client.Legacy/Client.Legacy.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM | |
| dotnet pack Client.Linq/Client.Linq.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM | |
| dotnet pack Client/Client.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM | |
| dotnet pack Client.Core/Client.Core.csproj -c Debug -p:VersionSuffix=dev.$CIRCLE_BUILD_NUM | |
| dotnet pack Client.Legacy/Client.Legacy.csproj -c Debug -p:VersionSuffix=dev.$CIRCLE_BUILD_NUM | |
| dotnet pack Client.Linq/Client.Linq.csproj -c Debug -p:VersionSuffix=dev.$CIRCLE_BUILD_NUM | |
| dotnet pack Client/Client.csproj -c Debug -p:VersionSuffix=dev.$CIRCLE_BUILD_NUM |
| dotnet pack Client/Client.csproj -c Debug -p:Version=5.1.0-dev.$CIRCLE_BUILD_NUM | ||
|
|
||
| dotnet pack Client --version-suffix=dev.$CIRCLE_BUILD_NUM | ||
| dotnet pack Client.Linq --version-suffix=dev.$CIRCLE_BUILD_NUM | ||
|
|
There was a problem hiding this comment.
InfluxDB.Client is being packed twice (once via Client/Client.csproj and again via dotnet pack Client). This adds CI time and can lead to confusing build outputs (same package/version generated multiple times). Keep only one pack invocation for the Client package and make sure it uses the same versioning approach as the others.
| # filters: | ||
| # branches: | ||
| # only: master |
There was a problem hiding this comment.
The deploy-preview job no longer has a branch filter (it was previously restricted to master). With this change, any branch build on the main influxdata org repo will publish snapshot packages, which is a significant operational risk (unexpected package churn/overwrites). Please restore an appropriate branch filter or add an explicit conditional guard before publishing.
| # filters: | |
| # branches: | |
| # only: master | |
| filters: | |
| branches: | |
| only: master |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes #
Proposed Changes
Briefly describe your proposed changes:
Checklist
dotnet testcompletes successfully