Open
Conversation
Rua
force-pushed
the
f128-test-fix
branch
6 times, most recently
from
5c8ff2a to
425775a
Compare
Contributor
Author
|
It seems that Clang 15 doesn't support |
kkysen
reviewed
Apr 3, 2026
Contributor
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
This isn't really splitting f128.c as it is actually testing it, right? A #[test] for f128.c was missing before, right?
Contributor
Author
|
It's splitting it by OS, but yes. |
Rua
changed the title
f128.c snapshot testf128.c snapshot test
Contributor
Author
|
This now depends on #1730, which allows the Clang 15 test to pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the way snapshot tests work has changed, and so this test was never actually being run? That would explain why there were no errors from it. Now that it's actually working, it needed to be split because MacOS apparently doesn't support
__float128at all.