Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions c2rust-transpile/src/c_ast/conversion.rs
Original file line number Diff line number Diff line change
Expand Up @@ -388,17 +388,23 @@ impl ConversionContext {

/// Add a `CStmt` node into the `TypedAstContext`
fn add_stmt(&mut self, id: ImporterId, stmt: CStmt) {
self.typed_context.c_stmts.insert(CStmtId(id), stmt);
let id = CStmtId(id);
self.typed_context.add_stmt_parents(id, &stmt.kind);
self.typed_context.c_stmts.insert(id, stmt);
}

/// Add a `CExpr` node into the `TypedAstContext`
fn add_expr(&mut self, id: ImporterId, expr: CExpr) {
self.typed_context.c_exprs.insert(CExprId(id), expr);
let id = CExprId(id);
self.typed_context.add_expr_parents(id, &expr.kind);
self.typed_context.c_exprs.insert(id, expr);
}

/// Add a `CDecl` node into the `TypedAstContext`
fn add_decl(&mut self, id: ImporterId, decl: CDecl) {
self.typed_context.c_decls.insert(CDeclId(id), decl);
let id = CDeclId(id);
self.typed_context.add_decl_parents(id, &decl.kind);
self.typed_context.c_decls.insert(id, decl);
}

/// Clang has `Expression <: Statement`, but we want to make that explicit via the
Expand Down Expand Up @@ -561,7 +567,6 @@ impl ConversionContext {
&'a mut self,
untyped_context: &'a AstContext,
node: &'a AstNode,
new_id: ImporterId,
) -> impl Iterator<Item = CDeclId> + 'a {
use self::node_types::*;

Expand All @@ -573,7 +578,6 @@ impl ConversionContext {
.expect("child node not found");

let id = CDeclId(self.visit_node_type(decl, FIELD_DECL | ENUM_DECL | RECORD_DECL));
self.typed_context.parents.insert(id, CDeclId(new_id));

if decl_node.tag == ASTEntryTag::TagFieldDecl {
Some(id)
Expand Down Expand Up @@ -2164,9 +2168,7 @@ impl ConversionContext {
.iter()
.map(|id| {
let con = id.expect("Enum constant not found");
let id = CDeclId(self.visit_node_type(con, ENUM_CON));
self.typed_context.parents.insert(id, CDeclId(new_id));
id
CDeclId(self.visit_node_type(con, ENUM_CON))
})
.collect();

Expand Down Expand Up @@ -2269,10 +2271,7 @@ impl ConversionContext {
from_value(node.extras[6].clone()).expect("Expected struct alignment");

let fields: Option<Vec<CDeclId>> = if has_def {
Some(
self.visit_record_children(untyped_context, node, new_id)
.collect(),
)
Some(self.visit_record_children(untyped_context, node).collect())
} else {
None
};
Expand Down Expand Up @@ -2300,10 +2299,7 @@ impl ConversionContext {
let attrs = from_value::<Vec<Value>>(node.extras[2].clone())
.expect("Expected attribute array on record");
let fields: Option<Vec<CDeclId>> = if has_def {
Some(
self.visit_record_children(untyped_context, node, new_id)
.collect(),
)
Some(self.visit_record_children(untyped_context, node).collect())
} else {
None
};
Expand Down
31 changes: 0 additions & 31 deletions c2rust-transpile/src/c_ast/iterators.rs
Original file line number Diff line number Diff line change
@@ -1,36 +1,5 @@
use crate::c_ast::*;

#[derive(Copy, Clone, Eq, PartialEq, Debug, Hash)]
pub enum SomeId {
Stmt(CStmtId),
Expr(CExprId),
Decl(CDeclId),
Type(CTypeId),
}

macro_rules! from_some_id {
( $field_type:ty, $con_name:ident, $proj_name:ident ) => {
impl From<$field_type> for SomeId {
fn from(a: $field_type) -> Self {
SomeId::$con_name(a)
}
}
impl SomeId {
pub fn $proj_name(self) -> Option<$field_type> {
match self {
SomeId::$con_name(x) => Some(x),
_ => None,
}
}
}
};
}

from_some_id!(CExprId, Expr, expr);
from_some_id!(CStmtId, Stmt, stmt);
from_some_id!(CDeclId, Decl, decl);
from_some_id!(CTypeId, Type, type_);

/// Like the vec macro except that it calls the into method on all list elements
macro_rules! intos {
( $( $x:expr ),* ) => { vec![ $( $x.into(), )* ] };
Expand Down
Loading
Loading