Skip to content

update deps and workflows#102

Closed
crueter wants to merge 1 commit intoilammy:masterfrom
Eden-CI:master
Closed

update deps and workflows#102
crueter wants to merge 1 commit intoilammy:masterfrom
Eden-CI:master

Conversation

@crueter
Copy link
Copy Markdown

@crueter crueter commented Apr 9, 2026

this is a combined PR of a bunch of other people's PRs--mostly dep updates/node24 compat

Feel free to use this as needed

Signed-off-by: crueter <crueter@eden-emu.dev>
@pzhlkj6612
Copy link
Copy Markdown
Contributor

why? #101

@crueter
Copy link
Copy Markdown
Author

crueter commented Apr 9, 2026

this is a combined PR of a bunch of other people's PRs--mostly dep updates/node24 compat

Consider reading carefully next time: this is a combined PR of a bunch of other people's PRs--mostly dep updates/node24 compat

@pzhlkj6612
Copy link
Copy Markdown
Contributor

I of course read what you wrote. I mean, the exact difference is tiny:

https://github.com/ilammy/msvc-dev-cmd/compare/138b1c783b65ec697d8342918306b7b2db4e88f1..1bd71f95d6f3d1b2b3395b335cc63bcdc90cf223

Only in devDependencies.

this is a combined PR of a bunch of other people's PRs--mostly dep updates/node24 compat

And other guys' authorship has gone.

@crueter
Copy link
Copy Markdown
Author

crueter commented Apr 9, 2026

so in other words, a combined PR. Now quit pestering me, please.

@pzhlkj6612
Copy link
Copy Markdown
Contributor

My bad. Sorry.

@crueter
Copy link
Copy Markdown
Author

crueter commented Apr 9, 2026

I should fix the authorship though, good shout.

though, ilammy seems inactive, so idk if this will ever get merged. for now it's just for people to reference in workflows, ig

@crueter
Copy link
Copy Markdown
Author

crueter commented Apr 9, 2026

Okay I also came off very harsh, sorry about that... self-reminder to not open PRs at 2AM

@crueter
Copy link
Copy Markdown
Author

crueter commented Apr 9, 2026

Actually this was the wrong branch. Oops. I'll redo this later.

@crueter crueter closed this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants