Conversation
serenayl
approved these changes
Sep 29, 2022
Contributor
serenayl
left a comment
serenayl
left a comment
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BACKGROUND:
The API for creating textures for materials in Elements currently takes a relative file path and writes an image file to disk internally. This will not work for wasm scenarios where disk i/o operations are forbidden.
DESCRIPTION:
This pull request adds two new APIs to
Material, enabling the user to build materials frombyte[]and fromImage<Rgba32>objects. Additionally, it extends the current relative path support to more robustUrisupport, including absolute and relative file paths usingfile://, and protocols likehttp://andhttps://.TESTING:
REQUIRED:
CHANGELOG.md.This change is