Use SplitInternalLoops before Polygon is creation (Issue #881)#1043
Open
DmytroMuravskyi wants to merge 2 commits intohypar-io:masterfrom
Open
Use SplitInternalLoops before Polygon is creation (Issue #881)#1043DmytroMuravskyi wants to merge 2 commits intohypar-io:masterfrom
DmytroMuravskyi wants to merge 2 commits intohypar-io:masterfrom
Conversation
If ToPolygon throws the exception - SplitInternalLoops inside ToProfile has no chance to split loop into several valid loops. Also, Polygon should also go though SplitInternalLoops, not only profile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BACKGROUND:
DESCRIPTION:
SplitInternalLoopsandRemoveSequentialDuplicatesare moved to Vector3 static section for better reusability.DeleteVerticesForOverlappingEdges,RemoveSequentialDuplicatesandSplitInternalLoopsso Polygons are created from already split loops.ToPolygonnow returns list of Polygon.Profile.Unionso it usesPolyTreeas other functions and notList<List<ClipperLib.IntPoint>>();Profile.Clipas it was not used and was hard to update. In my opinion there is no value in keeping it around.TESTING:
DifferenceProduceTwoResultsInOneLoop()test.REQUIRED:
CHANGELOG.md.This change is