Skip to content

Refactor: remove aicpu_build_graph runtime#701

Merged
jvjhfhg merged 1 commit intohw-native-sys:mainfrom
ChaoWao:refactor/remove-aicpu-build-graph-runtime
Apr 29, 2026
Merged

Refactor: remove aicpu_build_graph runtime#701
jvjhfhg merged 1 commit intohw-native-sys:mainfrom
ChaoWao:refactor/remove-aicpu-build-graph-runtime

Conversation

@ChaoWao
Copy link
Copy Markdown
Collaborator

@ChaoWao ChaoWao commented Apr 29, 2026

Summary

All aicpu_build_graph features have been merged into
tensormap_and_ringbuffer, so the standalone runtime is no longer
needed. This change removes it entirely.

  • Delete src/a2a3/runtime/aicpu_build_graph/ and the corresponding ST
    test tree under tests/st/a2a3/aicpu_build_graph/
  • Drop the test_discovers_aicpu_build_graph discovery test and the
    matching skip clause in tests/conftest.py
  • Drop ABG_EXAMPLE_CASES and the runtime branch from
    tools/benchmark_rounds.sh; redirect the verify_packaging.sh smoke
    test to the tensormap_and_ringbuffer paged_attention_unroll case
  • Remove the runtime from issue templates, .claude rules / skills /
    commands, READMEs, the per-arch runtime docs, the tensor-dump and
    dynamic-linking docs, and the L2 perf header comments

Additional cleanups

  • Fix stale verification-matrix copy: tools/README.md,
    tools/verify_packaging.sh, and docs/python-packaging.md all said
    "5 install paths × 4 entry points" but only two user-facing entry
    points exist (pytest, standalone test_*.py); update to "× 2"
  • Update tools/README.md to refer to the single TMR_EXAMPLE_CASES
    map in benchmark_rounds.sh (was "EXAMPLE_CASES maps … per runtime"
    back when ABG had its own map)
  • Widen the scene-test retry from rc==124 only to any non-zero rc
    in all four spots (st-sim-a2a3, st-sim-a5, st-onboard-a2a3,
    st-onboard-a5), so transient PTO-ISA git-clone failures (e.g.
    SSL_ERROR_SYSCALL) trigger the pinned-commit retry instead of
    failing the job outright

Testing

  • Simulation tests pass
  • Hardware tests pass

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the aicpu_build_graph runtime variant from the repository, leaving host_build_graph and tensormap_and_ringbuffer as the remaining supported runtimes. The deletion includes the runtime's source code, headers, build configurations, and all associated examples and tests. Documentation, issue templates, and various tools and scripts have been updated to reflect this architectural simplification. I have no feedback to provide.

@ChaoWao ChaoWao force-pushed the refactor/remove-aicpu-build-graph-runtime branch from 3ab2aed to ec3d79d Compare April 29, 2026 09:51
All aicpu_build_graph features have been merged into
tensormap_and_ringbuffer; the standalone runtime is no longer needed.

- Delete src/a2a3/runtime/aicpu_build_graph/ and the corresponding ST
  test tree under tests/st/a2a3/aicpu_build_graph/
- Drop the test_discovers_aicpu_build_graph discovery test and the
  matching skip clause in tests/conftest.py
- Drop ABG_EXAMPLE_CASES and runtime branch from
  tools/benchmark_rounds.sh; redirect the verify_packaging.sh smoke
  test to the tensormap_and_ringbuffer paged_attention_unroll case
- Remove the runtime from issue templates, .claude rules/skills/
  commands, READMEs, the per-arch runtime docs, the tensor-dump and
  dynamic-linking docs, and the L2 perf header comments
- Fix stale verification-matrix copy: tools/README.md, the
  verify_packaging.sh banner, and docs/python-packaging.md all said
  "5 install paths x 4 entry points" but only two user-facing entry
  points exist (pytest, standalone test_*.py); update to "x 2"
- Update tools/README.md to refer to the single TMR_EXAMPLE_CASES map
  in benchmark_rounds.sh (was "EXAMPLE_CASES maps ... per runtime"
  back when ABG had its own map)
- Widen the scene-test retry from rc==124 only to any non-zero rc
  in all four spots (st-sim-a2a3, st-sim-a5, st-onboard-a2a3,
  st-onboard-a5), so transient PTO-ISA git-clone failures (e.g.
  SSL_ERROR_SYSCALL) trigger the pinned-commit retry instead of
  failing the job outright
@ChaoWao ChaoWao force-pushed the refactor/remove-aicpu-build-graph-runtime branch from ec3d79d to ff3b0e6 Compare April 29, 2026 10:46
@jvjhfhg jvjhfhg merged commit acf3900 into hw-native-sys:main Apr 29, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants