Refactor: remove aicpu_build_graph runtime#701
Merged
jvjhfhg merged 1 commit intohw-native-sys:mainfrom Apr 29, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the aicpu_build_graph runtime variant from the repository, leaving host_build_graph and tensormap_and_ringbuffer as the remaining supported runtimes. The deletion includes the runtime's source code, headers, build configurations, and all associated examples and tests. Documentation, issue templates, and various tools and scripts have been updated to reflect this architectural simplification. I have no feedback to provide.
3ab2aed to
ec3d79d
Compare
All aicpu_build_graph features have been merged into tensormap_and_ringbuffer; the standalone runtime is no longer needed. - Delete src/a2a3/runtime/aicpu_build_graph/ and the corresponding ST test tree under tests/st/a2a3/aicpu_build_graph/ - Drop the test_discovers_aicpu_build_graph discovery test and the matching skip clause in tests/conftest.py - Drop ABG_EXAMPLE_CASES and runtime branch from tools/benchmark_rounds.sh; redirect the verify_packaging.sh smoke test to the tensormap_and_ringbuffer paged_attention_unroll case - Remove the runtime from issue templates, .claude rules/skills/ commands, READMEs, the per-arch runtime docs, the tensor-dump and dynamic-linking docs, and the L2 perf header comments - Fix stale verification-matrix copy: tools/README.md, the verify_packaging.sh banner, and docs/python-packaging.md all said "5 install paths x 4 entry points" but only two user-facing entry points exist (pytest, standalone test_*.py); update to "x 2" - Update tools/README.md to refer to the single TMR_EXAMPLE_CASES map in benchmark_rounds.sh (was "EXAMPLE_CASES maps ... per runtime" back when ABG had its own map) - Widen the scene-test retry from rc==124 only to any non-zero rc in all four spots (st-sim-a2a3, st-sim-a5, st-onboard-a2a3, st-onboard-a5), so transient PTO-ISA git-clone failures (e.g. SSL_ERROR_SYSCALL) trigger the pinned-commit retry instead of failing the job outright
ec3d79d to
ff3b0e6
Compare
jvjhfhg
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All
aicpu_build_graphfeatures have been merged intotensormap_and_ringbuffer, so the standalone runtime is no longerneeded. This change removes it entirely.
src/a2a3/runtime/aicpu_build_graph/and the corresponding STtest tree under
tests/st/a2a3/aicpu_build_graph/test_discovers_aicpu_build_graphdiscovery test and thematching skip clause in
tests/conftest.pyABG_EXAMPLE_CASESand the runtime branch fromtools/benchmark_rounds.sh; redirect theverify_packaging.shsmoketest to the
tensormap_and_ringbufferpaged_attention_unrollcase.clauderules / skills /commands, READMEs, the per-arch runtime docs, the tensor-dump and
dynamic-linking docs, and the L2 perf header comments
Additional cleanups
tools/README.md,tools/verify_packaging.sh, anddocs/python-packaging.mdall said"5 install paths × 4 entry points" but only two user-facing entry
points exist (pytest, standalone
test_*.py); update to "× 2"tools/README.mdto refer to the singleTMR_EXAMPLE_CASESmap in
benchmark_rounds.sh(was "EXAMPLE_CASES maps … per runtime"back when ABG had its own map)
rc==124only to any non-zero rcin all four spots (
st-sim-a2a3,st-sim-a5,st-onboard-a2a3,st-onboard-a5), so transient PTO-ISA git-clone failures (e.g.SSL_ERROR_SYSCALL) trigger the pinned-commit retry instead offailing the job outright
Testing