Skip to content

fix: switch toString w/ toLocaleString to be able to format numbers in formatDiff#269

Open
moaali wants to merge 1 commit intohustcc:masterfrom
moaali:to-locale-string-fix
Open

fix: switch toString w/ toLocaleString to be able to format numbers in formatDiff#269
moaali wants to merge 1 commit intohustcc:masterfrom
moaali:to-locale-string-fix

Conversation

@moaali
Copy link
Copy Markdown

@moaali moaali commented Mar 18, 2024

This PR fixes the issue of displaying numbers in english all the time regardless of the selected locale by adding numberLocale option

Issue was: منذ 3 دقائق showing english number in arabic

With this PR you can do this:

render(node, 'ar', { numberLocale: 'ar-u-nu-arab' })

and it takes the correct form: منذ ٣ دقائق

@cr-gpt
Copy link
Copy Markdown

cr-gpt bot commented Mar 18, 2024

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant